Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flag to override listening address on serve #76

Open
KenFigueiredo opened this issue Jun 27, 2024 · 1 comment
Open

Support flag to override listening address on serve #76

KenFigueiredo opened this issue Jun 27, 2024 · 1 comment

Comments

@KenFigueiredo
Copy link

Hey there!

I'm attempting to run the credential-helper in a container within Kubernetes where it is a standalone pod in serve mode.
Currently this runs into issues where I'm unable to reach the application running in serve mode due to the listening address binding being hardcoded to 127.0.0.1.

I've ran some manual validation where I've changed: https://github.com/aws/rolesanywhere-credential-helper/blob/main/aws_signing_helper/serve.go#L23 to 0.0.0.0 and this seems to resolve the issue.

To support this use case it would be worthwhile to add an additional startup flag --listening-addr that overrides that value but defaults to localhost to keep the current behavior.

Thanks!

@dwmw2
Copy link
Contributor

dwmw2 commented Jun 27, 2024

This should not be limited to Legacy IP only. It's over a quarter of a century since the IPv6 standard was published.

@KenFigueiredo KenFigueiredo changed the title Support flag to override listening address Support flag to override listening address on serve Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants