Skip to content

Commit 6d52a81

Browse files
rsareddy0329Roja Reddy Sareddy
and
Roja Reddy Sareddy
authored
Fix: fix the issue due to PR changes, 5122 (#5124)
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job * Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview * Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication --------- Co-authored-by: Roja Reddy Sareddy <[email protected]>
1 parent 99b1b81 commit 6d52a81

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/sagemaker/processing.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -314,14 +314,15 @@ def _normalize_args(
314314
"code argument has to be a valid S3 URI or local file path "
315315
+ "rather than a pipeline variable"
316316
)
317+
317318
if arguments is not None:
318319
processed_arguments = []
319320
for arg in arguments:
320321
if isinstance(arg, PipelineVariable):
321322
processed_value = json.dumps(arg.expr)
322323
processed_arguments.append(processed_value)
323324
else:
324-
processed_arguments.append(str(arg))
325+
processed_arguments.append(arg)
325326
arguments = processed_arguments
326327

327328
self._current_job_name = self._generate_current_job_name(job_name=job_name)

tests/unit/sagemaker/workflow/test_processing_step.py

+3
Original file line numberDiff line numberDiff line change
@@ -824,12 +824,14 @@ def test_spark_processor(spark_processor, processing_input, pipeline_session):
824824
processor, run_inputs = spark_processor
825825
processor.sagemaker_session = pipeline_session
826826
processor.role = ROLE
827+
827828
arguments_output = [
828829
"--input",
829830
"input-data-uri",
830831
"--output",
831832
'{"Get": "Parameters.MyArgOutput"}',
832833
]
834+
833835
run_inputs["inputs"] = processing_input
834836

835837
step_args = processor.run(**run_inputs)
@@ -1024,6 +1026,7 @@ def test_spark_processor_local_code(spark_processor, processing_input, pipeline_
10241026
processor, run_inputs = spark_processor
10251027
processor.sagemaker_session = pipeline_session
10261028
processor.role = ROLE
1029+
10271030
arguments_output = [
10281031
"--input",
10291032
"input-data-uri",

0 commit comments

Comments
 (0)