Skip to content

Commit 5e4133d

Browse files
Generate s3 test file instead of checking it into source (#452)
* replace s3 put test file with a temp generated one
1 parent f6bc9fb commit 5e4133d

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

test/resources/s3_put_object.txt

-1
This file was deleted.

test/test_s3.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ def setUp(self):
135135
self.put_test_object_path = "/put_object_test_py_10MB.txt"
136136
self.region = "us-west-2"
137137
self.bucket_name = "aws-crt-canary-bucket"
138-
self.default_file_path = "test/resources/s3_put_object.txt"
139138
self.timeout = 100 # seconds
140139
self.num_threads = 0
141140
self.non_ascii_file_name = "ÉxÅmple.txt".encode("utf-8")
@@ -150,6 +149,7 @@ def setUp(self):
150149
self.put_body_stream = None
151150

152151
self.files = FileCreator()
152+
self.temp_put_obj_file_path = self.files.create_file_with_size("temp_put_obj_10mb", 10 * MB)
153153
super().setUp()
154154

155155
def tearDown(self):
@@ -223,7 +223,7 @@ def test_get_object(self):
223223
self._test_s3_put_get_object(request, S3RequestType.GET_OBJECT)
224224

225225
def test_put_object(self):
226-
request = self._put_object_request(self.default_file_path)
226+
request = self._put_object_request(self.temp_put_obj_file_path)
227227
self._test_s3_put_get_object(request, S3RequestType.PUT_OBJECT)
228228
self.put_body_stream.close()
229229

@@ -288,15 +288,15 @@ def test_get_object_file_object(self):
288288
os.remove(file.name)
289289

290290
def test_put_object_file_object(self):
291-
request = self._put_object_request(self.default_file_path)
291+
request = self._put_object_request(self.temp_put_obj_file_path)
292292
request_type = S3RequestType.PUT_OBJECT
293293
# close the stream, to test if the C FILE pointer as the input stream working well.
294294
self.put_body_stream.close()
295295
s3_client = s3_client_new(False, self.region, 5 * MB)
296296
s3_request = s3_client.make_request(
297297
request=request,
298298
type=request_type,
299-
send_filepath=self.default_file_path,
299+
send_filepath=self.temp_put_obj_file_path,
300300
on_headers=self._on_request_headers,
301301
on_progress=self._on_progress)
302302
finished_future = s3_request.finished_future
@@ -434,7 +434,7 @@ def test_put_object_quick_cancel(self):
434434
return self._put_object_cancel_helper(False)
435435

436436
def test_multipart_upload_with_invalid_request(self):
437-
request = self._put_object_request(self.default_file_path)
437+
request = self._put_object_request(self.temp_put_obj_file_path)
438438
request.headers.set("Content-MD5", "something")
439439
self._test_s3_put_get_object(request, S3RequestType.PUT_OBJECT, "AWS_ERROR_S3_INVALID_RESPONSE_STATUS")
440440
self.put_body_stream.close()

0 commit comments

Comments
 (0)