Skip to content

Commit 9c0c063

Browse files
authored
Finish dropping python 3.7 (#600)
When we dropped support for python 3.7 in #598 we forgot to update setup.py, and the README
1 parent 28383c3 commit 9c0c063

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/ci.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ env:
1313
PACKAGE_NAME: aws-crt-python
1414
LINUX_BASE_IMAGE: ubuntu-18-x64
1515
RUN: ${{ github.run_id }}-${{ github.run_number }}
16-
CRT_CI_ROLE: ${{ secrets.CRT_CI_ROLE_ARN }}
16+
CRT_CI_ROLE: ${{ secrets.CRT_CI_ROLE_ARN }}
1717
AWS_DEFAULT_REGION: us-east-1
1818

1919
jobs:
@@ -231,7 +231,7 @@ jobs:
231231
- name: Build ${{ env.PACKAGE_NAME }} + consumers
232232
run: |
233233
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
234-
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --python "C:\\hostedtoolcache\\windows\\Python\\3.7.9\\${{ matrix.arch }}\\python.exe"
234+
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --python "C:\\hostedtoolcache\\windows\\Python\\3.8.10\\${{ matrix.arch }}\\python.exe"
235235
236236
237237
macos:
@@ -293,7 +293,7 @@ jobs:
293293
version: ${{ matrix.version }}
294294
cpu_count: 4
295295
shell: bash
296-
environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN AWS_DEFAULT_REGION
296+
environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN AWS_DEFAULT_REGION
297297
run: |
298298
sudo pkg_add awscli py3-pip py3-urllib3
299299
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz', 'builder')"
@@ -321,7 +321,7 @@ jobs:
321321
version: '14.0'
322322
cpu_count: 4
323323
shell: bash
324-
environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN AWS_DEFAULT_REGION
324+
environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN AWS_DEFAULT_REGION
325325
run: |
326326
sudo pkg install -y python3 devel/py-pip net/py-urllib3 devel/py-awscli cmake
327327
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz', 'builder')"
@@ -335,7 +335,7 @@ jobs:
335335
- uses: actions/checkout@v4
336336
with:
337337
submodules: true
338-
- name: Run tests
338+
- name: Run tests
339339
run: |
340340
python3 -m pip install --upgrade --requirement requirements-dev.txt
341341
python3 -m pip install . --verbose

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ This library is licensed under the Apache 2.0 License.
1313

1414
## Minimum Requirements:
1515

16-
* Python 3.7+
16+
* Python 3.8+
1717

1818
## Installation
1919

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ def _load_version():
466466
"Operating System :: Unix",
467467
"Operating System :: MacOS",
468468
],
469-
python_requires='>=3.7',
469+
python_requires='>=3.8',
470470
ext_modules=[awscrt_ext()],
471471
cmdclass={'build_ext': awscrt_build_ext, "bdist_wheel": bdist_wheel_abi3},
472472
test_suite='test',

0 commit comments

Comments
 (0)