Add format attribute on logging functions (#47)

marcomagdy · web-flow · commit a9dccbf0b2ae · 2019-06-13T16:03:27.000-07:00
Prevents using the wrong format specifier.
diff --git a/include/aws/logging/logging.h b/include/aws/logging/logging.h
@@ -27,7 +27,7 @@ enum class verbosity {
 
 void log(verbosity v, char const* tag, char const* msg, va_list args);
 
-static inline void log_error(char const* tag, char const* msg, ...)
+[[gnu::format(printf, 2, 3)]] static inline void log_error(char const* tag, char const* msg, ...)
 {
     va_list args;
     va_start(args, msg);
@@ -37,7 +37,7 @@ static inline void log_error(char const* tag, char const* msg, ...)
     (void)msg;
 }
 
-static inline void log_info(char const* tag, char const* msg, ...)
+[[gnu::format(printf, 2, 3)]] static inline void log_info(char const* tag, char const* msg, ...)
 {
 #if AWS_LAMBDA_LOG >= 1
     va_list args;
@@ -50,7 +50,7 @@ static inline void log_info(char const* tag, char const* msg, ...)
 #endif
 }
 
-static inline void log_debug(char const* tag, char const* msg, ...)
+[[gnu::format(printf, 2, 3)]] static inline void log_debug(char const* tag, char const* msg, ...)
 {
 #if AWS_LAMBDA_LOG >= 2
     va_list args;

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ enum class verbosity {`
`27`	`27`
`28`	`28`	`void log(verbosity v, char const* tag, char const* msg, va_list args);`
`29`	`29`
`30`		`-static inline void log_error(char const* tag, char const* msg, ...)`
	`30`	`+[[gnu::format(printf, 2, 3)]] static inline void log_error(char const* tag, char const* msg, ...)`
`31`	`31`	`{`
`32`	`32`	`va_list args;`
`33`	`33`	`va_start(args, msg);`
`@@ -37,7 +37,7 @@ static inline void log_error(char const* tag, char const* msg, ...)`
`37`	`37`	`(void)msg;`
`38`	`38`	`}`
`39`	`39`
`40`		`-static inline void log_info(char const* tag, char const* msg, ...)`
	`40`	`+[[gnu::format(printf, 2, 3)]] static inline void log_info(char const* tag, char const* msg, ...)`
`41`	`41`	`{`
`42`	`42`	`#if AWS_LAMBDA_LOG >= 1`
`43`	`43`	`va_list args;`
`@@ -50,7 +50,7 @@ static inline void log_info(char const* tag, char const* msg, ...)`
`50`	`50`	`#endif`
`51`	`51`	`}`
`52`	`52`
`53`		`-static inline void log_debug(char const* tag, char const* msg, ...)`
	`53`	`+[[gnu::format(printf, 2, 3)]] static inline void log_debug(char const* tag, char const* msg, ...)`
`54`	`54`	`{`
`55`	`55`	`#if AWS_LAMBDA_LOG >= 2`
`56`	`56`	`va_list args;`