Fix error handling

axllent · axllent · commit 22cae16e00a9 · 2024-12-01T14:49:01.000+13:00
diff --git a/internal/storage/search.go b/internal/storage/search.go
@@ -190,15 +190,15 @@ func DeleteSearch(search, timezone string) error {
 			}
 		}
 
-		err = tx.Commit()
+		if err := tx.Commit(); err != nil {
+			return err
+		}
 
 		if err := pruneUnusedTags(); err != nil {
 			return err
 		}
 
-		if err == nil {
-			logger.Log().Debugf("[db] deleted %d messages matching %s", total, search)
-		}
+		logger.Log().Debugf("[db] deleted %d messages matching %s", total, search)
 
 		dbLastAction = time.Now()
 

Original file line number	Diff line number	Diff line change
`@@ -190,15 +190,15 @@ func DeleteSearch(search, timezone string) error {`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`
`193`		`- err = tx.Commit()`
	`193`	`+ if err := tx.Commit(); err != nil {`
	`194`	`+ return err`
	`195`	`+ }`
`194`	`196`
`195`	`197`	`if err := pruneUnusedTags(); err != nil {`
`196`	`198`	`return err`
`197`	`199`	`}`
`198`	`200`
`199`		`- if err == nil {`
`200`		`- logger.Log().Debugf("[db] deleted %d messages matching %s", total, search)`
`201`		`- }`
	`201`	`+ logger.Log().Debugf("[db] deleted %d messages matching %s", total, search)`
`202`	`202`
`203`	`203`	`dbLastAction = time.Now()`
`204`	`204`