Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "minimum supported axoupdater version" checks #1392

Closed
Gankra opened this issue Sep 4, 2024 · 1 comment · Fixed by #1432
Closed

Add "minimum supported axoupdater version" checks #1392

Gankra opened this issue Sep 4, 2024 · 1 comment · Fixed by #1432
Labels
feature request New feature or request

Comments

@Gankra
Copy link
Contributor

Gankra commented Sep 4, 2024

While many installer changes can be done in a forward/backward-compatible way with axoupdater, some changes, like #1355, strictly require the installed version of axoupdater to be new enough to be aware of the new behaviour. As such they are dangerous to land without some way to tell cargo-dist users "hey you must update axoupdater".

Given we already use guppy/cargo-metadata, we have dependency info at our fingertips and can in fact complain that you're using an older version of axoupdater.

So this feature amounts to:

  • add some constant in cargo-dist that records the minimum supported axoupdater version
  • for each distable package, if we see it depends on axoupdater as a library, complain if the axoupdater version is < the constant

We don't currently process dependency information so someone will need to write that logic. I'm reasonably familiar with the relevant APIs.

@mistydemeo
Copy link
Contributor

Note that we'll need to remove this line to actually calculate the deps:

metadata_cmd.no_deps();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants