Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 release candidates generate wrong link in release.yml #1761

Open
andrewdavidmackenzie opened this issue Feb 12, 2025 · 1 comment
Open

Comments

@andrewdavidmackenzie
Copy link

I have updated to

and run cargo dist init to refresh release.yml.

I see it has:

      - name: Install dist
        # we specify bash to get pipefail; it guards against the `curl` command
        # failing. otherwise `sh` won't catch that `curl` returned non-0
        shell: bash
        run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh"

My builds now fail thus: https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857

Run curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh
  curl --proto '=https' --tlsv1.[2](https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857#step:3:2) -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GH_TOKEN: ***
curl: (22) The requested URL returned error: [4](https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857#step:3:4)04

When I navigate to the release and the shell installer link I get: https://github.com/axodotdev/cargo-dist/releases/tag/v1.0.0-rc.1 and then the file named dist-install.sh, resulting in the url: https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/dist-installer.sh

I think that is the cause of the 404, as one is dist-installer.shvs. cargo-dist-installer.sh

@duckinator
Copy link
Contributor

Thank you for reporting this! v1.0 is very much unfinished, and it might be a bit before the next v1.0 release candidate which would address this.

I'd recommend using the latest stable version (v0.28.0) if you can, in the meantime.

I'll see if this can be sorted in the next few days. (Unfortunately I'm out for the rest of today due to an appointment, so won't be able to properly dig into it until tomorrow.)

@duckinator duckinator changed the title Download link incorrect in release.yml v1.0 release candidates generate wrong link in release.yml Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants