Updater: cross-platform compatibility, robustness enhancements #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the updater with the goal of ensuring it runs across all platforms and that it requires fewer external tools. Since these tools aren't preinstalled on Windows, it should ensure that running on Windows just works the same as on other platforms. In particular:
curl
call has been replaced by a call toreqwest
, which was already used in the crate for other things. This should also ensure it works on minimal Linux docker images, some of which come withwget
but nocurl
preinstalled.The call totar -xzf
has been replaced with Rust calls to decompress the tarball using theflate2
crate and then extract using thetar
crate, ensuring that tarball extraction will be possible on Windows.