Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater: cross-platform compatibility, robustness enhancements #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mistydemeo
Copy link
Collaborator

@mistydemeo mistydemeo commented Apr 30, 2024

This makes a few changes to the updater with the goal of ensuring it runs across all platforms and that it requires fewer external tools. Since these tools aren't preinstalled on Windows, it should ensure that running on Windows just works the same as on other platforms. In particular:

  • The external curl call has been replaced by a call to reqwest, which was already used in the crate for other things. This should also ensure it works on minimal Linux docker images, some of which come with wget but no curl preinstalled.
  • The calls to Unix commands to move and rename files have been replaced with calls to the Rust stdlib.
  • Executable file permissions are handled via Rust stdlib calls, and are now only run on Unix; these permissions don't exist on Windows.
  • The call to tar -xzf has been replaced with Rust calls to decompress the tarball using the flate2 crate and then extract using the tar crate, ensuring that tarball extraction will be possible on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants