Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitter: Replacement transactions might not be accepted in mempool #218

Open
Lazar955 opened this issue Feb 10, 2025 · 0 comments · May be fixed by #232
Open

Submitter: Replacement transactions might not be accepted in mempool #218

Lazar955 opened this issue Feb 10, 2025 · 0 comments · May be fixed by #232
Assignees
Labels

Comments

@Lazar955
Copy link
Member

Lazar955 commented Feb 10, 2025

Replacement transactions might be rejected due to:

  1. Non-standard transactions.
  2. Failure to meet Replace-by-Fee (RBF) minimum feerate.

Issue Details

In resendSecondTxOfCheckpointToBTC, if the required replacement fee exceeds the change output, the entire change is used as fees. This can result in a dust output, making the transaction non-standard.

Additionally, since fees are capped by the change output, the transaction may fail to meet RBF minimum feerate. There are also no validations ensuring that the replacement fee is greater than the sum of the original transactions or that it covers the bandwidth cost.

Recommendation

  1. Ensure replacement transactions do not produce dust outputs.
  2. Validate that replacement transactions meet the minimum required feerate.
  3. Implement additional checks to ensure compliance with mempool replacement policies.

BP2-019

@Lazar955 Lazar955 linked a pull request Feb 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants