Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIFO patch #5

Closed
N-R-K opened this issue Aug 6, 2021 · 1 comment
Closed

FIFO patch #5

N-R-K opened this issue Aug 6, 2021 · 1 comment

Comments

@N-R-K
Copy link

N-R-K commented Aug 6, 2021

I think you might be interested in FIFO/pipe support -- This patch allows you do read from stdin, so you can do something like curl 'https://link.to/image.png' | sxiv /dev/stdin which is much more saner than adding networking to the image viewer itself.

Also the xresources patch in this repo seems to be using NULL as a default fallback, as I mentioned here I believe it's better to use fg/bg as fallback in order to stay consistent with the default sxiv behavior.

bakkeby added a commit that referenced this issue Sep 7, 2021
@bakkeby
Copy link
Owner

bakkeby commented Sep 7, 2021

Yes I see this has some overlap with the libcurl patch, but very little. I had to add a quick hack to make it work with the animated webp support, but other than that it seems to work.

Also the xresources patch in this repo seems to be using NULL as a default fallback, as I mentioned here I believe it's better to use fg/bg as fallback in order to stay consistent with the default sxiv behavior.

Yes definitely using fg/bg as fallback makes perfect sense. Now there is this other patch which controls whether the foreground and background colours are swapped for the bar. It makes sense respect this swapping if it is falling back to using the normal fg/bg colours, but it does not make as much sense to do this if the user has specified separate colours for the bar via xresources. Because of this I intentionally set the default fallback to NULL so that I could differentiate between whether the user has defined separate colours for the bar or not. It falls back to the fg or bg colours later on if the background colours are NULL (i.e. not set via xresources). So it is merely defaulting to NULL for compatibility reasons.

@N-R-K N-R-K closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants