Skip to content

Commit 5c2a6f1

Browse files
author
Mike.lifeguard
committed
Fetch a data set known to be large in the test suite
Previously, we requested a list of pages from a namespace that had been cleaned up, leaving less than 500 pages. Instead, use the User namespace, which still has lots of pages. This should resolve some spurious test failures.
1 parent 868ed45 commit 5c2a6f1

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

t/14-get_pages_in_namespace.t

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,18 @@ if(defined($ENV{'PWPMakeTestSetWikiHost'})) {
1414
$bot->set_wiki($ENV{'PWPMakeTestSetWikiHost'}, $ENV{'PWPMakeTestSetWikiDir'});
1515
}
1616

17-
my $namespace_id = 10;
18-
my $page_limit = 1;
19-
20-
my @pages = $bot->get_pages_in_namespace($namespace_id);
21-
like($pages[0], qr/^Template:/, 'Template namespace found');
17+
my $template_ns = 10;
18+
my @pages = $bot->get_pages_in_namespace($template_ns);
19+
like $pages[0] => qr/^Template:/, 'Template namespace found';
2220

23-
@pages = $bot->get_pages_in_namespace($namespace_id, $page_limit);
24-
is(scalar @pages, $page_limit, 'Correct number of pages retrieved');
25-
26-
$namespace_id = 'non-existent';
27-
@pages = $bot->get_pages_in_namespace($namespace_id);
21+
my $page_limit = 1;
22+
@pages = $bot->get_pages_in_namespace($template_ns, $page_limit);
23+
is scalar @pages, $page_limit, 'Correct number of pages retrieved';
2824

29-
is($pages[0], undef, 'Error code received');
30-
is($bot->{error}->{code}, 3, 'Error code in MediaWiki::Bot object');
25+
@pages = $bot->get_pages_in_namespace('non-existent');
26+
is $pages[0], undef, 'Error code received';
27+
is $bot->{error}->{code}, 3, 'Error code in MediaWiki::Bot object';
3128

32-
$namespace_id = 6;
33-
@pages = $bot->get_pages_in_namespace($namespace_id, 'max', { max => 0 });
34-
cmp_ok(scalar @pages, '>', 500, 'Got more than 500 pages'); # RT 66790
29+
@pages = $bot->get_pages_in_namespace(2, 'max', { max => 0 });
30+
cmp_ok scalar @pages, '>', 500, 'Got more than 500 pages'
31+
or diag explain \@pages; # RT 66790

0 commit comments

Comments
 (0)