Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Motion UI #77

Open
soumak77 opened this issue Sep 3, 2016 · 0 comments
Open

Refactor Motion UI #77

soumak77 opened this issue Sep 3, 2016 · 0 comments

Comments

@soumak77
Copy link
Contributor

soumak77 commented Sep 3, 2016

ZURB has decoupled the Motion UI logic into its own library. Since Motion UI is used by Foundation for Sites, I think it would be safe to assume the library will be maintained as needed. Worst case we just create a new version of the library under Base Apps as we have for the other unmaintained libraries from ZURB.

Only the SCSS code will be used from Motion UI. Angular Base Apps will still provide the integration with angular instead of using the jQuery support provided by Motion UI.

The class naming convention for the motion css classes has changed from camelCasing to kebob-casing in ZURB's Motion UI. Since the library provides mixins, Angular Base Apps could keep the camelCasing naming convention, but I would prefer to stick to the same convention as Motion UI. The support for Motion UI classes can be added in a dot release, but deprecation of the current naming convention will need to wait for a major release.

@soumak77 soumak77 added this to the 3.0 Release milestone Sep 3, 2016
@soumak77 soumak77 added the motion label Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant