wip

Author: basicdays

package-lock.json

@@ -38,14 +38,9 @@
         "watch:babel": "npm run build:babel -- --watch",
         "watch:tsc": "npm run build:tsc -- --watch --preserveWatchOutput"
     },
-    "dependencies": {
-        "@babel/runtime": "^7.17.7",
-        "core-js-pure": "^3.21.1"
-    },
     "devDependencies": {
         "@babel/cli": "^7.17.6",
         "@babel/core": "^7.17.7",
-        "@babel/plugin-transform-runtime": "^7.17.0",
         "@babel/preset-env": "^7.16.11",
         "@babel/preset-typescript": "^7.16.7",
         "@babel/register": "^7.17.7",
@@ -57,7 +52,6 @@
         "@typescript-eslint/eslint-plugin": "^5.15.0",
         "@typescript-eslint/parser": "^5.15.0",
         "babel-plugin-istanbul": "^6.1.1",
-        "babel-plugin-polyfill-corejs3": "^0.5.2",
         "chai": "^4.3.6",
         "chai-as-promised": "^7.1.1",
         "eslint": "^8.11.0",
@@ -82,21 +76,6 @@
             ],
             "@babel/preset-typescript"
         ],
-        "plugins": [
-            [
-                "@babel/plugin-transform-runtime",
-                {
-                    "version": "7.17"
-                }
-            ],
-            [
-                "babel-plugin-polyfill-corejs3",
-                {
-                    "method": "usage-pure",
-                    "version": "3.21"
-                }
-            ]
-        ],
         "env": {
             "cover": {
                 "plugins": [

package.json

@@ -1,4 +1,4 @@
-import fs from "fs";
+import fs, { ReadStream } from "fs";
 import path from "path";
 import { Readable } from "stream";
 
@@ -7,13 +7,33 @@ import { expect } from "chai";
 import S2A from "./stream-to-async-iterator";
 
 describe("StreamToAsyncIterator", function () {
+    let defaultFileStreamEndEvents = 0;
+
+    before(() => {
+        // I guess node 12/14 creates fs read streams with an end event
+        const fileStream = fs.createReadStream(filePath, { encoding: "utf8" });
+        defaultFileStreamEndEvents = fileStream.listenerCount("end");
+        fileStream.destroy();
+    });
+
     const filePath = path.join(__dirname, "test/lorem-ipsum.txt");
 
     function assertClosed(stream: Readable, iter: S2A) {
         expect(stream).to.have.property("destroyed", true);
-        expect(stream.listenerCount("readable")).to.equal(0);
-        expect(stream.listenerCount("end")).to.equal(0);
-        expect(stream.listenerCount("error")).to.equal(0);
+        expect(stream.listenerCount("readable")).to.equal(
+            0,
+            "Stream readable events was not 0"
+        );
+        const endEvents =
+            stream instanceof ReadStream ? defaultFileStreamEndEvents : 0;
+        expect(stream.listenerCount("end")).to.equal(
+            endEvents,
+            `Stream end events was not ${endEvents}`
+        );
+        expect(stream.listenerCount("error")).to.equal(
+            0,
+            "Stream error events was not 0"
+        );
         expect(iter).to.have.property("closed", true);
     }