Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Zig master appears to have broken codebase. #26

Open
sk3p7ic opened this issue Oct 5, 2024 · 1 comment
Open

Current Zig master appears to have broken codebase. #26

sk3p7ic opened this issue Oct 5, 2024 · 1 comment

Comments

@sk3p7ic
Copy link
Contributor

sk3p7ic commented Oct 5, 2024

Hello,

I was looking at your repository and encountered issues when building the tests. When building, I used your script to download the latest version of Zig. It appears that from ziglang/zig@6808ce2 and ziglang/zig@0fe3fd0 in the Zig repository there were breaking changes introduced, such as

  • Migrated builtin function @setCold $\rightarrow$ @branchHint
  • Updated Type values (Void $\rightarrow$ void, Enum $\rightarrow$ @"enum")

It appears that these changes have also broken your GH Actions, such as https://github.com/batiati/mustache-zig/actions/runs/11177137203/job/31072011349#step:6:1786.

@CashWasabi
Copy link
Contributor

CashWasabi commented Jan 21, 2025

Hey there,
I created a PR fixing issues with the latest PR #30.
The test have been successful with the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants