Skip to content

Commit db093e9

Browse files
upgrade to latest dependencies (knative-extensions#203)
bumping knative.dev/hack f08cb0d...59b0cf1: > 59b0cf1 Proper search for tags in Go files only (# 135) Signed-off-by: Knative Automation <[email protected]>
1 parent 67184ab commit db093e9

File tree

4 files changed

+11
-34
lines changed

4 files changed

+11
-34
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ require (
66
github.com/spf13/cobra v1.2.1
77
gotest.tools/v3 v3.0.3
88
knative.dev/client v0.28.1-0.20220111130713-1fcab77a0876
9-
knative.dev/hack v0.0.0-20220110200259-f08cb0dcdee7
9+
knative.dev/hack v0.0.0-20220111151514-59b0cf17578e
1010

1111
)

go.sum

+2-1
Original file line numberDiff line numberDiff line change
@@ -1730,8 +1730,9 @@ knative.dev/eventing v0.28.1-0.20220107145225-eb4c06c8009d/go.mod h1:rJnn9hsSYQ8
17301730
knative.dev/hack v0.0.0-20211122162614-813559cefdda/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
17311731
knative.dev/hack v0.0.0-20211203062838-e11ac125e707/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
17321732
knative.dev/hack v0.0.0-20211222071919-abd085fc43de/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
1733-
knative.dev/hack v0.0.0-20220110200259-f08cb0dcdee7 h1:TPnyJuwP2cRXUZvLFSkGPzc/gEavAnj/HcV1Ut7UA+U=
17341733
knative.dev/hack v0.0.0-20220110200259-f08cb0dcdee7/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
1734+
knative.dev/hack v0.0.0-20220111151514-59b0cf17578e h1:tESsFI1iMD2Al+6FZueFN9CddxJ8Fa2cd9KmyNINe3w=
1735+
knative.dev/hack v0.0.0-20220111151514-59b0cf17578e/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
17351736
knative.dev/hack/schema v0.0.0-20211222071919-abd085fc43de/go.mod h1:ffjwmdcrH5vN3mPhO8RrF2KfNnbHeCE2C60A+2cv3U0=
17361737
knative.dev/networking v0.0.0-20220107020122-0dbedcd88acf h1:1RqxCIJBwvpahPVNCfxEk4Z/z7nHgmBhPp7ba9A1My0=
17371738
knative.dev/networking v0.0.0-20220107020122-0dbedcd88acf/go.mod h1:kXbsW1qHQcwHyd7qV1bHeYxGysR6XHh/hCkEvk28R/s=

vendor/knative.dev/hack/presubmit-tests.sh

+7-31
Original file line numberDiff line numberDiff line change
@@ -138,42 +138,18 @@ function default_build_test_runner() {
138138
[[ -z "${go_pkg_dirs}" ]] && return ${failed}
139139
# Ensure all the code builds
140140
subheader "Checking that go code builds"
141-
local report
142-
report="$(mktemp)"
143-
local errors_go1=""
144-
local errors_go2=""
145-
if ! capture_output "${report}" go build -v ./... ; then
146-
failed=1
147-
# Consider an error message everything that's not a package name.
148-
errors_go1="$(grep -v '^\(github\.com\|knative\.dev\)/' "${report}" | sort | uniq)"
149-
fi
150141
# Get all build tags in go code (ignore /vendor, /hack and /third_party)
151142
local tags
152-
tags="$(grep -r '// +build' . \
153-
| grep -v '^./vendor/' | grep -v '^./hack/' | grep -v '^./third_party' \
154-
| cut -f3 -d' ' | tr ',' '\n' | sort | uniq | tr '\n' ' ')"
155-
local tagged_pkgs
156-
tagged_pkgs="$(grep -r '// +build' . \
157-
| grep -v '^./vendor/' | grep -v '^./hack/' | grep -v '^./third_party' \
158-
| grep ":// +build " | cut -f1 -d: | xargs dirname \
159-
| sort | uniq | tr '\n' ' ')"
160-
for pkg in ${tagged_pkgs}; do
161-
# `go test -c` lets us compile the tests but do not run them.
162-
if ! capture_output "${report}" go test -c -tags="${tags}" "${pkg}" ; then
163-
failed=1
164-
# Consider an error message everything that's not a successful test result.
165-
errors_go2+="$(grep -v '^\(ok\|\?\)\s\+\(github\.com\|knative\.dev\)/' "${report}")"
166-
fi
167-
# Remove unused generated binary, if any.
168-
rm -f e2e.test
169-
done
143+
tags="$(find . \
144+
-path './vendor' -prune -o -path './hack' -prune -o -path './third_party' -prune \
145+
-o -type f -name '*.go' -exec grep '// +build' {} + \
146+
| cut -f3 -d' ' | tr ',' '\n' | uniq | sort | tr '\n' ' ')"
147+
report_build_test Build_Go \
148+
go test -vet=off -tags "${tags}" -exec echo ./... || failed=2
170149

171-
local errors_go
172-
errors_go="$(echo -e "${errors_go1}\n${errors_go2}" | uniq)"
173-
create_junit_xml _build_tests Build_Go "${errors_go}"
174150
# Check that we don't have any forbidden licenses in our images.
175151
subheader "Checking for forbidden licenses"
176-
report_build_test Check_Licenses check_licenses || failed=1
152+
report_build_test Check_Licenses check_licenses || failed=3
177153
return ${failed}
178154
}
179155

vendor/modules.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ gotest.tools/v3/internal/source
2626
# knative.dev/client v0.28.1-0.20220111130713-1fcab77a0876
2727
## explicit
2828
knative.dev/client/pkg/kn/plugin
29-
# knative.dev/hack v0.0.0-20220110200259-f08cb0dcdee7
29+
# knative.dev/hack v0.0.0-20220111151514-59b0cf17578e
3030
## explicit
3131
knative.dev/hack

0 commit comments

Comments
 (0)