chore: green up macos & windows CI

Author: gregmagolan

.bazelrc

@@ -2,6 +2,27 @@
 # https://github.com/bazelbuild/rules_nodejs/issues/3695
 common --noenable_bzlmod
 
+# Specifies desired output mode for running tests.
+# Valid values are
+#   'summary' to output only test status summary
+#   'errors' to also print test logs for failed tests
+#   'all' to print logs for all tests
+#   'streamed' to output logs for all tests in real time
+#     (this will force tests to be executed locally one at a time regardless of --test_strategy value).
+common --test_output=errors
+
+# Turn on --incompatible_strict_action_env which was on by default
+# in Bazel 0.21.0 but turned off again in 0.22.0. Follow
+# https://github.com/bazelbuild/bazel/issues/7026 for more details.
+# This flag is needed to so that the bazel cache is not invalidated
+# when running bazel via `yarn bazel`.
+# See https://github.com/angular/angular/issues/27514.
+common --incompatible_strict_action_env
+
+# Turn off legacy external runfiles
+# This prevents accidentally depending on this feature, which Bazel will remove.
+common --nolegacy_external_runfiles
+
 # Load any settings specific to the current user.
 # .bazelrc.user should appear in .gitignore so that settings are not shared with team members
 # This needs to be last statement in this

e2e/nodejs_host/.bazelrc

@@ -0,0 +1,20 @@
+# Specifies desired output mode for running tests.
+# Valid values are
+#   'summary' to output only test status summary
+#   'errors' to also print test logs for failed tests
+#   'all' to print logs for all tests
+#   'streamed' to output logs for all tests in real time
+#     (this will force tests to be executed locally one at a time regardless of --test_strategy value).
+common --test_output=errors
+
+# Turn on --incompatible_strict_action_env which was on by default
+# in Bazel 0.21.0 but turned off again in 0.22.0. Follow
+# https://github.com/bazelbuild/bazel/issues/7026 for more details.
+# This flag is needed to so that the bazel cache is not invalidated
+# when running bazel via `yarn bazel`.
+# See https://github.com/angular/angular/issues/27514.
+common --incompatible_strict_action_env
+
+# Turn off legacy external runfiles
+# This prevents accidentally depending on this feature, which Bazel will remove.
+common --nolegacy_external_runfiles

e2e/nodejs_host/MODULE.bazel

@@ -26,17 +26,23 @@ use_repo(
     node,
     "node16",
     "node16_darwin_amd64",
+    "node16_darwin_arm64",
     "node16_linux_amd64",
+    "node16_linux_arm64",
     "node16_nvmrc",
     "node16_nvmrc_darwin_amd64",
+    "node16_nvmrc_darwin_arm64",
     "node16_nvmrc_linux_amd64",
+    "node16_nvmrc_linux_arm64",
     "node16_nvmrc_toolchains",
     "node16_nvmrc_windows_amd64",
     "node16_toolchains",
     "node16_windows_amd64",
     "nodejs",
     "nodejs_darwin_amd64",
+    "nodejs_darwin_arm64",
     "nodejs_linux_amd64",
+    "nodejs_linux_arm64",
     "nodejs_toolchains",
     "nodejs_windows_amd64",
 )

e2e/smoke/.bazelrc

@@ -0,0 +1,20 @@
+# Specifies desired output mode for running tests.
+# Valid values are
+#   'summary' to output only test status summary
+#   'errors' to also print test logs for failed tests
+#   'all' to print logs for all tests
+#   'streamed' to output logs for all tests in real time
+#     (this will force tests to be executed locally one at a time regardless of --test_strategy value).
+common --test_output=errors
+
+# Turn on --incompatible_strict_action_env which was on by default
+# in Bazel 0.21.0 but turned off again in 0.22.0. Follow
+# https://github.com/bazelbuild/bazel/issues/7026 for more details.
+# This flag is needed to so that the bazel cache is not invalidated
+# when running bazel via `yarn bazel`.
+# See https://github.com/angular/angular/issues/27514.
+common --incompatible_strict_action_env
+
+# Turn off legacy external runfiles
+# This prevents accidentally depending on this feature, which Bazel will remove.
+common --nolegacy_external_runfiles

e2e/smoke/BUILD.bazel

@@ -3,6 +3,12 @@ load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
 load("@bazel_skylib//rules:write_file.bzl", "write_file")
 load(":defs.bzl", "my_nodejs")
 
+not_windows = select({
+    # There isn't a published rosetta binary for windows as of Feb 2024
+    "@platforms//os:windows": ["@platforms//:incompatible"],
+    "//conditions:default": [],
+})
+
 # Trivial test fixture: a nodejs program that writes to a file
 write_file(
     name = "js",
@@ -67,10 +73,8 @@ diff_test(
     name = "test_genrule",
     file1 = "expected",
     file2 = "actual1",
-    tags = [
-        # diff_test has line endings issues on Windows
-        "skip-on-bazelci-windows",
-    ],
+    # diff_test has line endings issues on Windows
+    target_compatible_with = not_windows,
 )
 
 # Here, my_nodejs is a fake for something like nodejs_binary or
@@ -129,10 +133,8 @@ diff_test(
     name = "test_acorn",
     file1 = "actual2",
     file2 = "expected_ast.json",
-    tags = [
-        # diff_test has line endings issues on Windows
-        "skip-on-bazelci-windows",
-    ],
+    # diff_test has line endings issues on Windows
+    target_compatible_with = not_windows,
 )
 
 ################################################
@@ -177,10 +179,8 @@ diff_test(
     name = "test_require_acorn",
     file1 = "actual3",
     file2 = "expected_ast.json",
-    tags = [
-        # diff_test has line endings issues on Windows
-        "skip-on-bazelci-windows",
-    ],
+    # diff_test has line endings issues on Windows
+    target_compatible_with = not_windows,
 )
 
 ################################################