Skip to content

Commit bdcf53a

Browse files
tokongsaignas
andauthored
fix: formatting directive bugs in test (#2134)
I'm getting a build error in my builds because nogo complains about this bug. I guess I could configure my nogo to no check this code, but I think it should be fixed. --------- Co-authored-by: Ignas Anikevicius <[email protected]>
1 parent d7d2ce7 commit bdcf53a

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ A brief description of the categories of changes:
2727
### Changed
2828
* Nothing yet
2929

30+
### Fixed
31+
* (gazelle): Fix incorrect use of `t.Fatal`/`t.Fatalf` in tests.
32+
3033
### Added
3134
* Nothing yet
3235

gazelle/manifest/test/test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ import (
3333
func TestGazelleManifestIsUpdated(t *testing.T) {
3434
requirementsPath := os.Getenv("_TEST_REQUIREMENTS")
3535
if requirementsPath == "" {
36-
t.Fatalf("_TEST_REQUIREMENTS must be set")
36+
t.Fatal("_TEST_REQUIREMENTS must be set")
3737
}
3838

3939
manifestPath := os.Getenv("_TEST_MANIFEST")
4040
if manifestPath == "" {
41-
t.Fatalf("_TEST_MANIFEST must be set")
41+
t.Fatal("_TEST_MANIFEST must be set")
4242
}
4343

4444
manifestFile := new(manifest.File)
@@ -53,7 +53,7 @@ func TestGazelleManifestIsUpdated(t *testing.T) {
5353
manifestGeneratorHashPath, err := runfiles.Rlocation(
5454
os.Getenv("_TEST_MANIFEST_GENERATOR_HASH"))
5555
if err != nil {
56-
t.Fatal("failed to resolve runfiles path of manifest: %v", err)
56+
t.Fatalf("failed to resolve runfiles path of manifest: %v", err)
5757
}
5858

5959
manifestGeneratorHash, err := os.Open(manifestGeneratorHashPath)

0 commit comments

Comments
 (0)