Run buildifier to add missing loads (#581)

Run `buildifier --lint=fix  -r -v .`
Manually add dependencies to rules_cc where they are missing.

See: bazelbuild/bazel#25755

Author: comius

android/firebase-cloud-messaging/WORKSPACE

@@ -10,12 +10,13 @@ http_archive(
     sha256 = RULES_JVM_EXTERNAL_SHA,
     strip_prefix = "rules_jvm_external-%s" % RULES_JVM_EXTERNAL_TAG,
     url =
-    "https://github.com/bazelbuild/rules_jvm_external/releases/download/%s/rules_jvm_external-%s.tar.gz" % (RULES_JVM_EXTERNAL_TAG, RULES_JVM_EXTERNAL_TAG)
+        "https://github.com/bazelbuild/rules_jvm_external/releases/download/%s/rules_jvm_external-%s.tar.gz" % (RULES_JVM_EXTERNAL_TAG, RULES_JVM_EXTERNAL_TAG),
 )
 
 load("@rules_jvm_external//:defs.bzl", "maven_install")
 
 maven_install(
+    aar_import_bzl_label = "@rules_android//rules:rules.bzl",
     artifacts = [
         "com.google.firebase:firebase-messaging:17.0.0",
         "com.android.support:appcompat-v7:26.1.0",
@@ -30,9 +31,8 @@ maven_install(
         "https://maven.google.com",
         "https://repo1.maven.org/maven2",
     ],
-    version_conflict_policy = "pinned",
     use_starlark_android_rules = True,
-    aar_import_bzl_label = "@rules_android//rules:rules.bzl",
+    version_conflict_policy = "pinned",
 )
 
 load("@maven//:compat.bzl", "compat_repositories")
@@ -61,11 +61,15 @@ http_archive(
 )
 
 load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
+
 rules_android_prereqs()
+
 load("@rules_android//:defs.bzl", "rules_android_workspace")
+
 rules_android_workspace()
 
 load("@rules_android//rules:rules.bzl", "android_sdk_repository")
+
 # Requires that the ANDROID_HOME environment variable is set to the Android SDK path.
 android_sdk_repository(
     name = "androidsdk",

android/jetpack-compose/WORKSPACE

@@ -40,4 +40,3 @@ kotlin_repositories(
 load("@io_bazel_rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
 
 kt_register_toolchains()
-

android/ndk/MODULE.bazel

@@ -7,6 +7,7 @@ bazel_dep(name = "rules_android", version = "0.5.1")
 
 maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
 maven.install(
+    aar_import_bzl_label = "@rules_android//rules:rules.bzl",
     artifacts = [
         "androidx.appcompat:appcompat:1.5.1",
         "androidx.constraintlayout:constraintlayout:2.1.4",
@@ -25,6 +26,5 @@ maven.install(
         "https://repo1.maven.org/maven2",
     ],
     use_starlark_android_rules = True,
-    aar_import_bzl_label = "@rules_android//rules:rules.bzl",
 )
 use_repo(maven, "maven")

android/ndk/WORKSPACE

@@ -10,11 +10,15 @@ http_archive(
 )
 
 load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
+
 rules_android_prereqs()
+
 load("@rules_android//:defs.bzl", "rules_android_workspace")
+
 rules_android_workspace()
 
 load("@rules_android//rules:rules.bzl", "android_sdk_repository")
+
 # Requires that the ANDROID_HOME environment variable is set to the Android SDK path.
 android_sdk_repository(
     name = "androidsdk",

android/robolectric-testing/MODULE.bazel

@@ -5,7 +5,7 @@ bazel_dep(name = "rules_jvm_external", version = "5.3")
 
 maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
 maven.install(
-     artifacts = [
+    artifacts = [
         "org.robolectric:robolectric:4.9",
         "junit:junit:4.13.2",
         "com.google.truth:truth:1.1.3",
@@ -19,5 +19,4 @@ maven.install(
         "https://repo1.maven.org/maven2",
     ],
 )
-
 use_repo(maven, "maven")

bzlmod/01-depend_on_bazel_module/BUILD

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+
 cc_binary(
     name = "main",
     srcs = ["main.cc"],

bzlmod/01-depend_on_bazel_module/MODULE.bazel

@@ -3,6 +3,8 @@ module(
     version = "0.0.1",
 )
 
+bazel_dep(name = "rules_cc", version = "0.0.17")
+
 # 1. The metadata of glog is fetched from the BCR, including its dependencies (gflags).
 # 2. The `repo_name` attribute allows users to reference this dependency via the `com_github_google_glog` repo name.
 bazel_dep(name = "glog", version = "0.5.0", repo_name = "com_github_google_glog")

bzlmod/01-depend_on_bazel_module/WORKSPACE

@@ -1,5 +1,12 @@
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
+http_archive(
+    name = "rules_cc",
+    sha256 = "abc605dd850f813bb37004b77db20106a19311a96b2da1c92b789da529d28fe1",
+    strip_prefix = "rules_cc-0.0.17",
+    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.17/rules_cc-0.0.17.tar.gz"],
+)
+
 http_archive(
     name = "com_github_google_glog",
     sha256 = "eede71f28371bf39aa69b45de23b329d37214016e2055269b3b5e7cfd40b59f5",

bzlmod/02-override_bazel_module/BUILD

@@ -1,4 +1,5 @@
 load("@bazel_skylib//:version.bzl", "hello_msg")
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
 
 # buildifier: disable=print
 print(hello_msg)

bzlmod/02-override_bazel_module/MODULE.bazel

@@ -3,6 +3,7 @@ module(
     version = "0.0.1",
 )
 
+bazel_dep(name = "rules_cc", version = "0.0.17")
 bazel_dep(name = "glog", version = "0.5.0", repo_name = "com_github_google_glog")
 
 # Override glog to a fork version with archive_override.

bzlmod/02-override_bazel_module/WORKSPACE

@@ -1,6 +1,13 @@
 load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
+http_archive(
+    name = "rules_cc",
+    sha256 = "abc605dd850f813bb37004b77db20106a19311a96b2da1c92b789da529d28fe1",
+    strip_prefix = "rules_cc-0.0.17",
+    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.17/rules_cc-0.0.17.tar.gz"],
+)
+
 # Use a fork version of glog with http_archive.
 http_archive(
     name = "com_github_google_glog",

bzlmod/02-override_bazel_module/lib_a/BUILD

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 package(default_visibility = ["//visibility:public"])
 
 cc_library(

bzlmod/02-override_bazel_module/lib_a/MODULE.bazel

@@ -3,4 +3,5 @@ module(
     version = "0.0.1",
 )
 
+bazel_dep(name = "rules_cc", version = "0.0.17")
 bazel_dep(name = "glog", version = "0.5.0", repo_name = "com_github_google_glog")

configurations/MODULE.bazel

@@ -1,3 +1,4 @@
 "Bazel dependencies, see https://registry.bazel.build"
 
+bazel_dep(name = "rules_cc", version = "0.0.17")
 bazel_dep(name = "bazel_skylib", version = "1.7.1")

configurations/cc_binary_selectable_copts/BUILD

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 # This load statement replaces the native cc_binary (which has no "set_features"
 # attribute) with a macro that strings together the logic to make that work,
 # then passes everything else back to the native cc_binary.

configurations/cc_binary_selectable_copts/defs.bzl

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_binary.bzl", _cc_binary = "cc_binary")
+
 # buildifier: disable=module-docstring
 def _copt_transition_impl(_, attr):
     # settings provides read access to existing flags. But
@@ -84,7 +86,7 @@ def cc_binary(name, set_features = None, **kwargs):
         actual_binary = ":%s" % cc_binary_name,
         set_features = set_features,
     )
-    native.cc_binary(
+    _cc_binary(
         name = cc_binary_name,
         **kwargs
     )

configurations/cc_test/defs.bzl

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_test.bzl", "cc_test")
+
 # buildifier: disable=module-docstring
 # We can transition on native options using this
 # //command_line_option:<option-name> syntax
@@ -49,4 +51,4 @@ def test_arg_cc_test(name, **kwargs):
 
     # The native test is built as usual, but mark as "manual" so that blaze test :all
     # does not run it.
-    native.cc_test(name = cc_test_name, tags = kwargs.pop("tags", []) + ["manual"], **kwargs)
+    cc_test(name = cc_test_name, tags = kwargs.pop("tags", []) + ["manual"], **kwargs)

cpp-tutorial/stage1/MODULE.bazel

@@ -0,0 +1 @@
+bazel_dep(name = "rules_cc", version = "0.0.17")

cpp-tutorial/stage1/main/BUILD

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+
 cc_binary(
     name = "hello-world",
     srcs = ["hello-world.cc"],

cpp-tutorial/stage2/MODULE.bazel

@@ -0,0 +1 @@
+bazel_dep(name = "rules_cc", version = "0.0.17")

cpp-tutorial/stage2/main/BUILD

@@ -1,3 +1,6 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 cc_library(
     name = "hello-greet",
     srcs = ["hello-greet.cc"],

cpp-tutorial/stage3/MODULE.bazel

@@ -0,0 +1 @@
+bazel_dep(name = "rules_cc", version = "0.0.17")

cpp-tutorial/stage3/lib/BUILD

@@ -1,3 +1,5 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 cc_library(
     name = "hello-time",
     srcs = ["hello-time.cc"],

cpp-tutorial/stage3/main/BUILD

@@ -1,3 +1,6 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
 cc_library(
     name = "hello-greet",
     srcs = ["hello-greet.cc"],

frontend/react-webpack/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@aspect_rules_js//js:defs.bzl", "js_test")
-load("@npm//:defs.bzl", "npm_link_all_packages")
 load("@aspect_rules_webpack//webpack:defs.bzl", "webpack_bundle", "webpack_devserver")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 
 npm_link_all_packages()
 

macros/fancy_word_counter/defs.bzl

@@ -45,15 +45,15 @@ def _impl(name, visibility, srcs, out, make_it_loud, _shout_tool, **kwargs):
 fancy_count_words = macro(
     implementation = _impl,
     attrs = {
-        "srcs": attr.label_list(mandatory=True),
-        "out": attr.output(mandatory=True),
+        "srcs": attr.label_list(mandatory = True),
+        "out": attr.output(mandatory = True),
         # `configurable=False` means it can't be set to a select() by the user,
         # and won't be promoted to a select() when passed to the implementation
         # function. Morally, this should be used whenever the value is consumed
         # by the macro logic itself as opposed to being passed through to the
         # underlying targets.
-        "make_it_loud": attr.bool(default=False, configurable=False),
-        "_shout_tool": attr.label(default="//shout:shout.py", configurable=False),
+        "make_it_loud": attr.bool(default = False, configurable = False),
+        "_shout_tool": attr.label(default = "//shout:shout.py", configurable = False),
     },
     doc = """
     Wraps the count_words macro, adding a shouting (capitalization) feature.

macros/letter_metrics/defs.bzl

@@ -22,9 +22,9 @@ def _impl(name, visibility, deps, out, _aggregate_tool):
 generate_letter_frequencies = macro(
     implementation = _impl,
     attrs = {
-        "deps": attr.label_list(mandatory=True, configurable=False),
-        "out": attr.output(mandatory=True),
-        "_aggregate_tool": attr.label(default=":aggregate.py", configurable=False),
+        "deps": attr.label_list(mandatory = True, configurable = False),
+        "out": attr.output(mandatory = True),
+        "_aggregate_tool": attr.label(default = ":aggregate.py", configurable = False),
     },
     doc = """
     Emits a file summarizing letter frequency data generated by the count_words
@@ -33,7 +33,6 @@ generate_letter_frequencies = macro(
     """,
 )
 
-
 def _gather_impl(name, visibility, out):
     suffix = "_letter_freq"
     deps = []
@@ -52,12 +51,12 @@ def _gather_impl(name, visibility, out):
 gather_all_letter_frequencies = macro(
     implementation = _gather_impl,
     attrs = {
-        "out": attr.output(mandatory=True),
+        "out": attr.output(mandatory = True),
     },
     finalizer = True,
     doc = """
     Convenience finalizer form of generate_letter_frequencies, that
     automatically infers deps by grabbing targets named *_letter_freq
     from the current package.
-    """
+    """,
 )

macros/main/BUILD.bazel

@@ -1,6 +1,6 @@
-load("//word_counter:defs.bzl", "count_words")
 load("//fancy_word_counter:defs.bzl", "fancy_count_words")
 load("//letter_metrics:defs.bzl", "gather_all_letter_frequencies", "generate_letter_frequencies")
+load("//word_counter:defs.bzl", "count_words")
 
 # A simple symbolic macro.
 count_words(

macros/word_counter/defs.bzl

@@ -43,8 +43,8 @@ def _impl(name, visibility, srcs, out, _count_tool):
 count_words = macro(
     implementation = _impl,
     attrs = {
-        "srcs": attr.label_list(mandatory=True),
-        "out": attr.output(mandatory=True),
+        "srcs": attr.label_list(mandatory = True),
+        "out": attr.output(mandatory = True),
         # An alternative to having _count_tool be an implicit dependency attribute
         # would be to just reference the label directly in the implementation
         # function. There, we could create a local variable
@@ -57,7 +57,7 @@ count_words = macro(
         #
         # since that would resolve relative to the package this macro is
         # instantiated in, rather than relative to this .bzl file.
-        "_count_tool": attr.label(default=":counter.py", configurable=False),
+        "_count_tool": attr.label(default = ":counter.py", configurable = False),
     },
     doc = """
     Emits a file containing a few of the most frequently occurring words in the

make-variables/WORKSPACE

@@ -0,0 +1,6 @@
+http_archive(
+    name = "rules_cc",
+    sha256 = "abc605dd850f813bb37004b77db20106a19311a96b2da1c92b789da529d28fe1",
+    strip_prefix = "rules_cc-0.0.17",
+    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.17/rules_cc-0.0.17.tar.gz"],
+)

make-variables/testapp/BUILD

@@ -1,3 +1,4 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
 load("//testapp:defs.bzl", "var_providing_rule")
 
 # Targets demonstrating predefined variables available to all rules:

query-quickstart/src/main/java/com/example/customers/BUILD

@@ -1,3 +1,5 @@
+load("@rules_java//java:java_library.bzl", "java_library")
+
 java_library(
     name = "amir",
     srcs = ["Amir.java"],

query-quickstart/src/main/java/com/example/dishes/BUILD

@@ -1,3 +1,5 @@
+load("@rules_java//java:java_library.bzl", "java_library")
+
 java_library(
     name = "macAndCheese",
     srcs = ["MacAndCheese.java"],

query-quickstart/src/main/java/com/example/ingredients/BUILD

@@ -1,3 +1,5 @@
+load("@rules_java//java:java_library.bzl", "java_library")
+
 java_library(
     name = "cheese",
     srcs = ["Cheese.java"],

query-quickstart/src/main/java/com/example/restaurant/BUILD

@@ -1,3 +1,5 @@
+load("@rules_java//java:java_library.bzl", "java_library")
+
 java_library(
     name = "chef",
     srcs = [

query-quickstart/src/main/java/com/example/reviews/BUILD

@@ -1,3 +1,5 @@
+load("@rules_java//java:java_binary.bzl", "java_binary")
+
 java_binary(
     name = "review",
     srcs = [

rules/MODULE.bazel

@@ -2,6 +2,6 @@
 
 bazel_dep(name = "bazel_skylib", version = "1.7.1")
 bazel_dep(name = "rules_python", version = "0.25.0")
-bazel_dep(name = "rules_cc", version = "0.0.9")
+bazel_dep(name = "rules_cc", version = "0.0.17")
 bazel_dep(name = "platforms", version = "0.0.10")
-
+bazel_dep(name = "rules_shell", version = "0.4.0")

rules/actions_run/BUILD

@@ -1,3 +1,4 @@
+load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 load(":execute.bzl", "concat")
 
 concat(

rules/computed_dependencies/BUILD

@@ -1,3 +1,4 @@
+load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
 load(":hash.bzl", "md5_sum")
 
 # Run 'bazel build :hash_no_space' to compute the md5 sum of 'hello.txt'

rules/generating_code/BUILD

@@ -1,3 +1,6 @@
+load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+load("@rules_python//python:defs.bzl", "py_binary", "py_library")
 load("//generating_code/gen:enum_maker.bzl", "enum_maker")
 
 enum_maker(

rules/generating_code/gen/BUILD

@@ -2,6 +2,8 @@
 #
 # enum_maker is a tool that turns a list of values into an enum.
 
+load("@rules_python//python:defs.bzl", "py_binary")
+
 py_binary(
     name = "enum_maker",
     srcs = ["enum_maker.py"],