Skip to content

Commit 7615691

Browse files
committed
Enable bindgen tests for windows
1 parent 7584b08 commit 7615691

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

.bazelci/presubmit.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -918,20 +918,18 @@ tasks:
918918
- "//..."
919919
test_targets:
920920
- "//..."
921-
# # TODO: https://github.com/bazelbuild/rules_rust/issues/2009
922-
# # The bindgen rules are currently broken on windows
923-
# extensions_bindgen_windows:
924-
# platform: windows
925-
# name: Extensions Bindgen
926-
# working_directory: extensions/bindgen
927-
# build_flags: *aspects_flags
928-
# test_flags: *aspects_flags
929-
# build_targets:
930-
# - "--"
931-
# - "//..."
932-
# test_targets:
933-
# - "--"
934-
# - "//..."
921+
extensions_bindgen_windows:
922+
platform: windows
923+
name: Extensions Bindgen
924+
working_directory: extensions/bindgen
925+
build_flags: *aspects_flags
926+
test_flags: *aspects_flags
927+
build_targets:
928+
- "--"
929+
- "//..."
930+
test_targets:
931+
- "--"
932+
- "//..."
935933
extensions_mdbook_linux:
936934
platform: ubuntu2004
937935
name: Extensions MdBook

.bcr/extensions/bindgen/presubmit.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ bcr_test_module:
44
platform:
55
- "macos_arm64"
66
- "ubuntu2004"
7-
# # TODO: https://github.com/bazelbuild/rules_rust/issues/2009
8-
# - "windows"
7+
- "windows"
98
bazel: ["7.x"]
109
tasks:
1110
run_tests:

extensions/bindgen/private/bindgen.bzl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def _get_user_link_flags(cc_lib):
130130
return linker_flags
131131

132132
def _generate_cc_link_build_info(ctx, cc_lib):
133-
"""Produce the eqivilant cargo_build_script providers for use in linking the library.
133+
"""Produce the equivalent cargo_build_script providers for use in linking the library.
134134
135135
Args:
136136
ctx (ctx): The rule's context object
@@ -391,7 +391,10 @@ rust_bindgen = rule(
391391
default = True,
392392
),
393393
"wrap_static_fns": attr.bool(
394-
doc = "Whether to create a separate .c file for static fns. Requires nightly toolchain, and a header that actually needs this feature (otherwise bindgen won't generate the file and Bazel complains).",
394+
doc = (
395+
"Whether to create a separate .c file for static functions. Requires nightly toolchain, " +
396+
"and a header that actually needs this feature (otherwise bindgen won't generate the file and Bazel complains)."
397+
),
395398
default = False,
396399
),
397400
"_process_wrapper": attr.label(

0 commit comments

Comments
 (0)