Skip to content

Commit 9fb59c1

Browse files
committed
Enable bindgen tests for windows
1 parent ba49599 commit 9fb59c1

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

.bazelci/presubmit.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -909,20 +909,18 @@ tasks:
909909
- "//..."
910910
test_targets:
911911
- "//..."
912-
# # TODO: https://github.com/bazelbuild/rules_rust/issues/2009
913-
# # The bindgen rules are currently broken on windows
914-
# extensions_bindgen_windows:
915-
# platform: windows
916-
# name: Extensions Bindgen
917-
# working_directory: extensions/bindgen
918-
# build_flags: *aspects_flags
919-
# test_flags: *aspects_flags
920-
# build_targets:
921-
# - "--"
922-
# - "//..."
923-
# test_targets:
924-
# - "--"
925-
# - "//..."
912+
extensions_bindgen_windows:
913+
platform: windows
914+
name: Extensions Bindgen
915+
working_directory: extensions/bindgen
916+
build_flags: *aspects_flags
917+
test_flags: *aspects_flags
918+
build_targets:
919+
- "--"
920+
- "//..."
921+
test_targets:
922+
- "--"
923+
- "//..."
926924
extensions_prost_linux:
927925
platform: ubuntu2004
928926
name: Extensions Prost

.bcr/extensions/bindgen/presubmit.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ bcr_test_module:
44
platform:
55
- "macos_arm64"
66
- "ubuntu2004"
7-
# # TODO: https://github.com/bazelbuild/rules_rust/issues/2009
8-
# - "windows"
7+
- "windows"
98
bazel: ["7.x"]
109
tasks:
1110
run_tests:

extensions/bindgen/private/bindgen.bzl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def _get_user_link_flags(cc_lib):
130130
return linker_flags
131131

132132
def _generate_cc_link_build_info(ctx, cc_lib):
133-
"""Produce the eqivilant cargo_build_script providers for use in linking the library.
133+
"""Produce the equivalent cargo_build_script providers for use in linking the library.
134134
135135
Args:
136136
ctx (ctx): The rule's context object
@@ -391,7 +391,10 @@ rust_bindgen = rule(
391391
default = True,
392392
),
393393
"wrap_static_fns": attr.bool(
394-
doc = "Whether to create a separate .c file for static fns. Requires nightly toolchain, and a header that actually needs this feature (otherwise bindgen won't generate the file and Bazel complains).",
394+
doc = (
395+
"Whether to create a separate .c file for static functions. Requires nightly toolchain, " +
396+
"and a header that actually needs this feature (otherwise bindgen won't generate the file and Bazel complains)."
397+
),
395398
default = False,
396399
),
397400
"_cc_toolchain": attr.label(

0 commit comments

Comments
 (0)