Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize api for scopes #107

Open
jamiefolson opened this issue Feb 11, 2013 · 2 comments
Open

Standardize api for scopes #107

jamiefolson opened this issue Feb 11, 2013 · 2 comments

Comments

@jamiefolson
Copy link

Facebook scopes are supposed to be comma-separated. Google scopes are space-separated. Currently, velruse just assumes you know this and have properly formatted the scope string. It'd be great to not have to know this.

@jamiefolson
Copy link
Author

My idea would be to maintain backwards-compatibility by simply allowing the scope parameters to be passed as a list, which is then correctly formatted by velruse.

@mmerickel
Copy link
Collaborator

I think the supported options could be standardized but they'd have to remain strings because the scope can usually also be specified in the POST request to the login url (not just the settings). With that in mind, comma-separated would be good as long as it doesn't break google's scopes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants