code cleanup

Author: soletsdev

api/src/main/java/ca/bc/gov/educ/penreg/api/orchestrator/BaseReturnFilesOrchestrator.java

@@ -287,7 +287,7 @@ protected List<SchoolContact> getStudentRegistrationContactsByMincode(final PenR
       return this.getStudentRegistrationContactService().getStudentRegistrationContactsByMincode(penRequestBatchEntity.getMincode());
     } catch (final NullPointerException e) {
       log.error("Error while trying to get get student registration contact. The student registration contact map is null", e);
-      return null;
+      return Collections.emptyList();
     }
   }
 

api/src/test/java/ca/bc/gov/educ/penreg/api/rest/RestUtilsTest.java

@@ -245,7 +245,7 @@ public void testGetStudentRegistrationContacts_shouldReturnData() {
     when(this.responseMock.bodyToFlux(SchoolContactSearchWrapper.class)).thenReturn(Flux.just(createSchoolContactSearchWrapper()));
 
     final var result = this.restUtils.getStudentRegistrationContactList("10200001");
-    assertThat(result.size()).isEqualTo(2);
+    assertThat(result).hasSize(2);
     assertThat(result.get(0).getEmail()).isEqualTo("[email protected]");
     assertThat(result.get(0).getFirstName()).isEqualTo("Joe");
     assertThat(result.get(1).getEmail()).isEqualTo("[email protected]");