Improve subtask filtering logic

Author: trslater

alcs-frontend/src/app/features/board/dialogs/card-dialog/card-dialog.component.ts

@@ -79,9 +79,10 @@ export class CardDialogComponent implements OnInit, OnDestroy {
 
   filterAssigneeList(term: string, item: AssigneeDto) {
     const termLower = term.toLocaleLowerCase();
-    return item.email
-      ? item.email.toLocaleLowerCase().indexOf(termLower) > -1
-      : false || item.prettyName.toLocaleLowerCase().indexOf(termLower) > -1;
+    return (
+      (item.email && item.email.toLocaleLowerCase().indexOf(termLower) > -1) ||
+      item.prettyName.toLocaleLowerCase().indexOf(termLower) > -1
+    );
   }
 
   onArchiveCard() {

alcs-frontend/src/app/features/home/subtask/subtask-table/subtask-table.component.ts

@@ -57,9 +57,10 @@ export class SubtaskTableComponent {
 
   filterAssigneeList(term: string, item: AssigneeDto) {
     const termLower = term.toLocaleLowerCase();
-    return item.email
-      ? item.email.toLocaleLowerCase().indexOf(termLower) > -1
-      : false || item.prettyName.toLocaleLowerCase().indexOf(termLower) > -1;
+    return (
+      (item.email && item.email.toLocaleLowerCase().indexOf(termLower) > -1) ||
+      item.prettyName.toLocaleLowerCase().indexOf(termLower) > -1
+    );
   }
 
   async openCard(subtask: HomepageSubtaskDto) {