Add and fix tests

Author: Abradat

alcs-frontend/src/app/features/application/application.component.spec.ts

@@ -15,6 +15,7 @@ import { ApplicationSubmissionService } from '../../services/application/applica
 import { ApplicationSubmissionStatusService } from '../../services/application/application-submission-status/application-submission-status.service';
 
 import { ApplicationComponent } from './application.component';
+import { ApplicationDecisionConditionCardService } from '../../services/application/decision/application-decision-v2/application-decision-condition/application-decision-condition-card/application-decision-condition-card.service';
 
 describe('ApplicationComponent', () => {
   let component: ApplicationComponent;
@@ -25,6 +26,7 @@ describe('ApplicationComponent', () => {
   let mockReviewService: DeepMocked<ApplicationReviewService>;
   let mockAppSubmissionService: DeepMocked<ApplicationSubmissionService>;
   let mockAppStatusService: DeepMocked<ApplicationSubmissionStatusService>;
+  let mockApplicationDecisionConditionCardService: DeepMocked<ApplicationDecisionConditionCardService>;
 
   beforeEach(async () => {
     mockAppDetailService = createMock();
@@ -40,6 +42,8 @@ describe('ApplicationComponent', () => {
     mockAppSubmissionService = createMock();
     mockAppStatusService = createMock();
 
+    mockApplicationDecisionConditionCardService = createMock();
+
     await TestBed.configureTestingModule({
       providers: [
         {
@@ -70,6 +74,10 @@ describe('ApplicationComponent', () => {
           provide: ApplicationSubmissionStatusService,
           useValue: mockAppStatusService,
         },
+        {
+          provide: ApplicationDecisionConditionCardService,
+          useValue: mockApplicationDecisionConditionCardService,
+        },
         {
           provide: ActivatedRoute,
           useValue: {

services/apps/alcs/src/alcs/application-decision/application-decision-condition/application-decision-condition-card/application-decision-condition-card.controller.spec.ts

@@ -16,17 +16,20 @@ import { classes } from 'automapper-classes';
 import { ClsService } from 'nestjs-cls';
 import { mockKeyCloakProviders } from '../../../../../test/mocks/mockTypes';
 import { ApplicationDecisionProfile } from '../../../../common/automapper/application-decision-v2.automapper.profile';
+import { ApplicationDecisionV2Service } from '../../application-decision-v2/application-decision/application-decision-v2.service';
 
 describe('ApplicationDecisionConditionCardController', () => {
   let controller: ApplicationDecisionConditionCardController;
   let mockService: DeepMocked<ApplicationDecisionConditionCardService>;
   let mockModificationService: DeepMocked<ApplicationModificationService>;
   let mockReconsiderationService: DeepMocked<ApplicationReconsiderationService>;
+  let mockApplicationDecisionService: DeepMocked<ApplicationDecisionV2Service>;
 
   beforeEach(async () => {
     mockService = createMock();
     mockModificationService = createMock();
     mockReconsiderationService = createMock();
+    mockApplicationDecisionService = createMock();
 
     const module: TestingModule = await Test.createTestingModule({
       imports: [
@@ -48,6 +51,10 @@ describe('ApplicationDecisionConditionCardController', () => {
           provide: ApplicationReconsiderationService,
           useValue: mockReconsiderationService,
         },
+        {
+          provide: ApplicationDecisionV2Service,
+          useValue: mockApplicationDecisionService,
+        },
         {
           provide: ClsService,
           useValue: {},
@@ -116,11 +123,25 @@ describe('ApplicationDecisionConditionCardController', () => {
     mockService.getByBoardCard.mockResolvedValue(conditionCard);
     mockReconsiderationService.getByApplicationDecisionUuid.mockResolvedValue([]);
     mockModificationService.getByApplicationDecisionUuid.mockResolvedValue([]);
+    mockApplicationDecisionService.getDecisionOrder.mockResolvedValue(1);
 
     const result = await controller.getByCardUuid(uuid);
 
     expect(mockService.getByBoardCard).toHaveBeenCalledWith(uuid);
     expect(result).toBeInstanceOf(ApplicationDecisionConditionCardBoardDto);
     expect(result.fileNumber).toEqual('file-number');
   });
+
+  it('should return condition cards by application file number', async () => {
+    const fileNumber = 'example-file-number';
+    const conditionCard = new ApplicationDecisionConditionCard();
+    conditionCard.decision = { uuid: 'decision-uuid' } as any;
+    mockApplicationDecisionService.getForDecisionConditionCardsByFileNumber.mockResolvedValue([conditionCard]);
+
+    const result = await controller.getByApplicationFileNumber(fileNumber);
+
+    expect(mockApplicationDecisionService.getForDecisionConditionCardsByFileNumber).toHaveBeenCalledWith(fileNumber);
+    expect(result).toBeInstanceOf(Array);
+    expect(result[0]).toBeInstanceOf(ApplicationDecisionConditionCardDto);
+  });
 });