Merge pull request #2055 from bcgov/bugfix/ALCS-2370

2370: Improve error handling, properly catch upload errors

Author: trslater

alcs-frontend/src/app/features/application/application.module.ts

@@ -15,7 +15,6 @@ import { appChildRoutes, ApplicationComponent } from './application.component';
 import { BoundaryAmendmentComponent } from './boundary-amendment/boundary-amendment.component';
 import { EditBoundaryAmendmentDialogComponent } from './boundary-amendment/edit-boundary-amendment-dialog/edit-boundary-amendment-dialog.component';
 import { DecisionModule } from './decision/decision.module';
-import { DocumentUploadDialogComponent } from './documents/document-upload-dialog/document-upload-dialog.component';
 import { DocumentsComponent } from './documents/documents.component';
 import { InfoRequestsComponent } from './info-requests/info-requests.component';
 import { InfoRequestDialogComponent } from './info-requests/info-request-dialog/info-request-dialog.component';
@@ -73,7 +72,6 @@ const routes: Routes = [
     ApplicantInfoComponent,
     LfngInfoComponent,
     DocumentsComponent,
-    DocumentUploadDialogComponent,
     ProposalComponent,
     NfuProposalComponent,
     SubdProposalComponent,

alcs-frontend/src/app/features/application/decision/decision-v2/decision-documents/decision-documents.component.ts

@@ -8,7 +8,7 @@ import { ApplicationDecisionV2Service } from '../../../../../services/applicatio
 import { ApplicationDecisionDocumentDto } from '../../../../../services/application/decision/application-decision-v2/application-decision.dto';
 import { ToastService } from '../../../../../services/toast/toast.service';
 import { ConfirmationDialogService } from '../../../../../shared/confirmation-dialog/confirmation-dialog.service';
-import { DecisionDocumentUploadDialogComponent } from '../decision-input/decision-file-upload-dialog/decision-document-upload-dialog.component';
+import { DocumentUploadDialogComponent } from '../../../../../shared/document-upload-dialog/document-upload-dialog.component';
 import { FILE_NAME_TRUNCATE_LENGTH } from '../../../../../shared/constants';
 
 @Component({
@@ -102,14 +102,16 @@ export class DecisionDocumentsComponent implements OnInit, OnDestroy {
   private openFileDialog(existingDocument?: ApplicationDecisionDocumentDto) {
     if (this.decision) {
       this.dialog
-        .open(DecisionDocumentUploadDialogComponent, {
+        .open(DocumentUploadDialogComponent, {
           minWidth: '600px',
           maxWidth: '800px',
           width: '70%',
           data: {
             fileId: this.fileId,
             decisionUuid: this.decision?.uuid,
             existingDocument: existingDocument,
+            decisionService: this.decisionService,
+            allowedVisibilityFlags: ['A', 'C', 'G', 'P'],
           },
         })
         .beforeClosed()