Skip to content

Commit cd84d80

Browse files
trslatergithub-actions[bot]
authored andcommitted
Don't overwrite options object
1 parent f126192 commit cd84d80

File tree

4 files changed

+76
-8
lines changed

4 files changed

+76
-8
lines changed

alcs-frontend/src/app/features/application/documents/documents.component.ts

+20-4
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,15 @@ export class DocumentsComponent implements OnInit {
6363
}
6464

6565
async onUploadFile() {
66-
const submission = await this.applicationSubmissionService.fetchSubmission(this.fileId);
67-
const parcels = await this.applicationParcelService.fetchParcels(this.fileId);
66+
const data: DocumentUploadDialogData = {
67+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
68+
...{
69+
fileId: this.fileId,
70+
documentService: this.applicationDocumentService,
71+
parcelService: this.applicationParcelService,
72+
submissionService: this.applicationSubmissionService,
73+
},
74+
};
6875

6976
this.dialog
7077
.open(DocumentUploadDialogComponent, {
@@ -126,8 +133,17 @@ export class DocumentsComponent implements OnInit {
126133
}
127134

128135
async onEditFile(element: ApplicationDocumentDto) {
129-
const submission = await this.applicationSubmissionService.fetchSubmission(this.fileId);
130-
const parcels = await this.applicationParcelService.fetchParcels(this.fileId);
136+
const data: DocumentUploadDialogData = {
137+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
138+
...{
139+
allowsFileEdit: element.system === DOCUMENT_SYSTEM.ALCS,
140+
fileId: this.fileId,
141+
existingDocument: element,
142+
documentService: this.applicationDocumentService,
143+
parcelService: this.applicationParcelService,
144+
submissionService: this.applicationSubmissionService,
145+
},
146+
};
131147

132148
this.dialog
133149
.open(DocumentUploadDialogComponent, {

alcs-frontend/src/app/features/notice-of-intent/documents/documents.component.ts

+20-4
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,15 @@ export class NoiDocumentsComponent implements OnInit {
6767
}
6868

6969
async onUploadFile() {
70-
const submission = await this.noiSubmissionService.fetchSubmission(this.fileId);
71-
const parcels = await this.noiParcelService.fetchParcels(this.fileId);
70+
const data: DocumentUploadDialogData = {
71+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
72+
...{
73+
fileId: this.fileId,
74+
documentService: this.noiDocumentService,
75+
parcelService: this.noiParcelService,
76+
submissionService: this.noiSubmissionService,
77+
},
78+
};
7279

7380
this.dialog
7481
.open(DocumentUploadDialogComponent, {
@@ -116,8 +123,17 @@ export class NoiDocumentsComponent implements OnInit {
116123
}
117124

118125
async onEditFile(element: NoticeOfIntentDocumentDto) {
119-
const submission = await this.noiSubmissionService.fetchSubmission(this.fileId);
120-
const parcels = await this.noiParcelService.fetchParcels(this.fileId);
126+
const data: DocumentUploadDialogData = {
127+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
128+
...{
129+
allowsFileEdit: element.system === DOCUMENT_SYSTEM.ALCS,
130+
fileId: this.fileId,
131+
existingDocument: element,
132+
documentService: this.noiDocumentService,
133+
parcelService: this.noiParcelService,
134+
submissionService: this.noiSubmissionService,
135+
},
136+
};
121137

122138
this.dialog
123139
.open(DocumentUploadDialogComponent, {

alcs-frontend/src/app/features/notification/documents/documents.component.ts

+18
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ export class NotificationDocumentsComponent implements OnInit {
4848
}
4949

5050
async onUploadFile() {
51+
const data: DocumentUploadDialogData = {
52+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
53+
...{
54+
fileId: this.fileId,
55+
documentService: this.notificationDocumentService,
56+
},
57+
};
58+
5159
this.dialog
5260
.open(DocumentUploadDialogComponent, {
5361
minWidth: '600px',
@@ -91,6 +99,16 @@ export class NotificationDocumentsComponent implements OnInit {
9199
}
92100

93101
onEditFile(element: NoticeOfIntentDocumentDto) {
102+
const data: DocumentUploadDialogData = {
103+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
104+
...{
105+
allowsFileEdit: element.system === DOCUMENT_SYSTEM.ALCS,
106+
fileId: this.fileId,
107+
existingDocument: element,
108+
documentService: this.notificationDocumentService,
109+
},
110+
};
111+
94112
this.dialog
95113
.open(DocumentUploadDialogComponent, {
96114
minWidth: '600px',

alcs-frontend/src/app/features/planning-review/documents/documents.component.ts

+18
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ export class DocumentsComponent implements OnInit {
4848
}
4949

5050
async onUploadFile() {
51+
const data: DocumentUploadDialogData = {
52+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
53+
...{
54+
fileId: this.fileId,
55+
documentService: this.planningReviewDocumentService,
56+
},
57+
};
58+
5159
this.dialog
5260
.open(DocumentUploadDialogComponent, {
5361
minWidth: '600px',
@@ -91,6 +99,16 @@ export class DocumentsComponent implements OnInit {
9199
}
92100

93101
onEditFile(element: PlanningReviewDocumentDto) {
102+
const data: DocumentUploadDialogData = {
103+
...DOCUMENT_UPLOAD_DIALOG_OPTIONS,
104+
...{
105+
allowsFileEdit: element.system === DOCUMENT_SYSTEM.ALCS,
106+
fileId: this.fileId,
107+
existingDocument: element,
108+
documentService: this.planningReviewDocumentService,
109+
},
110+
};
111+
94112
this.dialog
95113
.open(DocumentUploadDialogComponent, {
96114
minWidth: '600px',

0 commit comments

Comments
 (0)