Merge pull request #2087 from bcgov/feature/ALCS-2484

Change Condition Index from Letter to Number

Author: Abradat

alcs-frontend/src/app/features/board/dialogs/application-decision-condition-dialog/application-decision-condition-dialog.component.ts

@@ -45,7 +45,7 @@ export class ApplicationDecisionConditionDialogComponent extends CardDialogCompo
   isReconsideration: boolean = false;
 
   @ViewChild(MatSort) sort!: MatSort;
-  dataSource: MatTableDataSource<{ condition: ApplicationDecisionConditionDto; index: string; selected: boolean }> =
+  dataSource: MatTableDataSource<{ condition: ApplicationDecisionConditionDto; index: number; selected: boolean }> =
     new MatTableDataSource();
 
   editColumns: string[] = ['select', 'condition', 'date', 'status'];
@@ -98,13 +98,15 @@ export class ApplicationDecisionConditionDialogComponent extends CardDialogCompo
   }
 
   loadTableData(filterSelected: boolean = false) {
-    const data = this.decision.conditions.map((condition, index) => ({
-      condition,
-      index: countToString(index + 1),
-      selected: this.isConditionSelected(condition),
-    }));
-
-    filterSelected ? (this.dataSource.data = data.filter((item) => item.selected)) : (this.dataSource.data = data);
+    const data = this.decision.conditions
+      .filter((condition) => !filterSelected || this.isConditionSelected(condition))
+      .map((condition, index) => ({
+        condition,
+        index: index + 1,
+        selected: this.isConditionSelected(condition),
+      }));
+
+    this.dataSource.data = data;
   }
 
   isConditionSelected(condition: ApplicationDecisionConditionDto): boolean {