From e0b9f7ec15df909595a83ac3cb5713bc4a8bd209 Mon Sep 17 00:00:00 2001
From: Tristan Slater <1631008+trslater@users.noreply.github.com>
Date: Tue, 11 Mar 2025 15:58:45 -0700
Subject: [PATCH] Replace condition that kept orders sane

---
 .../decision-condition-order-dialog.component.ts          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/alcs-frontend/src/app/features/application/decision/decision-v2/decision-input/decision-conditions/decision-condition-order-dialog/decision-condition-order-dialog.component.ts b/alcs-frontend/src/app/features/application/decision/decision-v2/decision-input/decision-conditions/decision-condition-order-dialog/decision-condition-order-dialog.component.ts
index 2b3d98b30..7947f29ec 100644
--- a/alcs-frontend/src/app/features/application/decision/decision-v2/decision-input/decision-conditions/decision-condition-order-dialog/decision-condition-order-dialog.component.ts
+++ b/alcs-frontend/src/app/features/application/decision/decision-v2/decision-input/decision-conditions/decision-condition-order-dialog/decision-condition-order-dialog.component.ts
@@ -90,7 +90,9 @@ export class DecisionConditionOrderDialogComponent implements OnInit {
 
   sendToBottom(record: ApplicationDecisionConditionDto) {
     this.conditionsToOrder.forEach((item) => {
-      item.order--;
+      if (item.order > record.order) {
+        item.order--;
+      }
     });
     record.order = this.conditionsToOrder.length - 1;
     this.dataSource.data = this.conditionsToOrder.sort((a, b) => a.order - b.order);
@@ -100,7 +102,9 @@ export class DecisionConditionOrderDialogComponent implements OnInit {
 
   sendToTop(record: ApplicationDecisionConditionDto) {
     this.conditionsToOrder.forEach((item) => {
-      item.order++;
+      if (item.order < record.order) {
+        item.order++;
+      }
     });
     record.order = 0;
     this.dataSource.data = this.conditionsToOrder.sort((a, b) => a.order - b.order);