ORV2-3450 Defunct/Zombie processes within Openshift dops pod environment after Financial Report Generation (#1811)

Co-authored-by: Chris Berg <[email protected]>

Author: praju-aot

charts/onroutebc/values.yaml

@@ -331,6 +331,8 @@ dops:
   containers:
     - name: dops
       command:
+        - "/usr/local/bin/dumb-init"
+        - "--"
         - "sh"
         - "-c"
         - "source /vault/secrets/keycloak-{{.Values.global.vault.zone}} && source /vault/secrets/mssql-{{.Values.global.vault.zone}} && source /vault/secrets/ches-{{.Values.global.vault.zone}} && source /vault/secrets/cdogs-{{.Values.global.vault.zone}} && source /vault/secrets/dops-{{.Values.global.vault.zone}} && source /vault/secrets/s3-{{.Values.global.vault.zone}} && npm run start:prod"

dops/Dockerfile

@@ -123,6 +123,9 @@ RUN apk add --no-cache \
 
 ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser
 
+# It's a good idea to use dumb-init to help prevent zombie chrome processes.
+ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.5/dumb-init_1.2.5_x86_64 /usr/local/bin/dumb-init
+RUN chmod +x /usr/local/bin/dumb-init
 
 # Add user so we don't need --no-sandbox.
 RUN addgroup -S pptruser && adduser -S -G pptruser pptruser \
@@ -136,6 +139,9 @@ USER pptruser
 # Expose Port
 EXPOSE 5001
 
+# It's a good idea to use dumb-init to help prevent zombie chrome processes.
+ENTRYPOINT ["dumb-init", "--"]
+
 # Start the app
 CMD ["npm", "run", "start:prod"]
 

dops/src/modules/dgen/dgen.service.ts

@@ -224,7 +224,7 @@ export class DgenService {
     let page: Page;
     try {
       browser = await puppeteer.launch({
-        args: [
+        args: [          
           '--no-sandbox',
           '--disable-gpu',
           '--disable-software-rasterizer',
@@ -240,6 +240,7 @@ export class DgenService {
           '--disable-client-side-phishing-detection',
           '--disable-extensions',
           '--disable-plugins',
+          '--disable-setuid-sandbox',
         ],
         pipe: true,
         headless: true,
@@ -272,6 +273,8 @@ export class DgenService {
         await page.close();
       }
       if (browser) {
+        const pages = await browser.pages();
+        await Promise.allSettled(pages?.map((page) => page.close()));
         await browser.close();
       }
     }

dops/src/modules/notification/notification.service.ts

@@ -87,9 +87,9 @@ export class NotificationService {
         'Content-Type': 'application/json',
         Authorization: 'Bearer ' + token,
         'Accept-Encoding': 'gzip, deflate, br', // Add compression support
-        'accept': 'application/json',
+        accept: 'application/json',
       },
-      responseType: 'json'
+      responseType: 'json',
     };
 
     // Sending the email through the HTTP service and handling the response