ci: removed ARGS and ENV from Dockerfile as envvars are RUNTIME and i… (#1838)

Author: cberg-aot

dops/Dockerfile

@@ -31,82 +31,6 @@ RUN mkdir /.cache && chmod 777 /.cache
 # Set the working directory to /app inside the deployment container
 WORKDIR /app
 
-# Set node to production
-ARG NODE_ENV
-ENV NODE_ENV=${NODE_ENV}
-
-
-ARG DB_TYPE
-ARG DOPS_API_LOG_LEVEL
-ARG DOPS_API_TYPEORM_LOG_LEVEL
-ARG DOPS_API_MAX_QUERY_EXECUTION_TIME_MS
-ARG DOPS_API_MSSQL_MAX_CONNECTION
-ARG MSSQL_HOST
-ARG MSSQL_PORT
-ARG MSSQL_DB
-ARG MSSQL_SA_USER
-ARG MSSQL_SA_PASSWORD
-ARG MSSQL_ENCRYPT
-ARG KEYCLOAK_ISSUER_URL
-ARG KEYCLOAK_AUDIENCE
-ARG KEYCLOAK_IGNORE_EXP
-ARG DOPS_CVSE_FORMS_CACHE_TTL_MS
-ARG OCIO_S3_ACCESSKEYID
-ARG OCIO_S3_BUCKET
-ARG OCIO_S3_PRESIGNED_URL_EXPIRY
-ARG OCIO_S3_ENDPOINT
-ARG OCIO_S3_KEY
-ARG OCIO_S3_SECRETACCESSKEY
-ARG CHES_TOKEN_URL
-ARG CHES_CLIENT_ID
-ARG CHES_CLIENT_SECRET
-ARG CHES_URL
-ARG CDOGS_TOKEN_URL
-ARG CDOGS_CLIENT_ID
-ARG CDOGS_CLIENT_SECRET
-ARG CDOGS_URL
-ARG ACCESS_API_URL
-ARG DOPS_URL
-ARG FRONTEND_URL
-ARG ORBC_SERVICE_ACCOUNT_CLIENT_ID
-ARG ORBC_SERVICE_ACCOUNT_AUDIENCE
-
-# Set environment variables
-ENV DB_TYPE=${DB_TYPE}
-ENV DOPS_API_LOG_LEVEL=${DOPS_API_LOG_LEVEL}
-ENV DOPS_API_TYPEORM_LOG_LEVEL=${DOPS_API_TYPEORM_LOG_LEVEL}
-ENV DOPS_API_MAX_QUERY_EXECUTION_TIME_MS=${DOPS_API_MAX_QUERY_EXECUTION_TIME_MS}
-ENV DOPS_API_MSSQL_MAX_CONNECTION=${DOPS_API_MSSQL_MAX_CONNECTION}
-ENV MSSQL_HOST=${MSSQL_HOST}
-ENV MSSQL_PORT=${MSSQL_PORT}
-ENV MSSQL_DB=${MSSQL_DB}
-ENV MSSQL_SA_USER=${MSSQL_SA_USER}
-ENV MSSQL_SA_PASSWORD=${MSSQL_SA_PASSWORD}
-ENV MSSQL_ENCRYPT=${MSSQL_ENCRYPT}
-ENV KEYCLOAK_ISSUER_URL=${KEYCLOAK_ISSUER_URL}
-ENV KEYCLOAK_AUDIENCE=${KEYCLOAK_AUDIENCE}
-ENV KEYCLOAK_IGNORE_EXP=${KEYCLOAK_IGNORE_EXP}
-ENV DOPS_CVSE_FORMS_CACHE_TTL_MS=${DOPS_CVSE_FORMS_CACHE_TTL_MS}
-ENV OCIO_S3_ACCESSKEYID=${OCIO_S3_ACCESSKEYID}
-ENV OCIO_S3_BUCKET=${OCIO_S3_BUCKET}
-ENV OCIO_S3_PRESIGNED_URL_EXPIRY=${OCIO_S3_PRESIGNED_URL_EXPIRY}
-ENV OCIO_S3_ENDPOINT=${OCIO_S3_ENDPOINT}
-ENV OCIO_S3_KEY=${OCIO_S3_KEY}
-ENV OCIO_S3_SECRETACCESSKEY=${OCIO_S3_SECRETACCESSKEY}
-ENV CHES_TOKEN_URL=${CHES_TOKEN_URL}
-ENV CHES_CLIENT_ID=${CHES_CLIENT_ID}
-ENV CHES_CLIENT_SECRET=${CHES_CLIENT_SECRET}
-ENV CHES_URL=${CHES_URL}
-ENV CDOGS_TOKEN_URL=${CDOGS_TOKEN_URL}
-ENV CDOGS_CLIENT_ID=${CDOGS_CLIENT_ID}
-ENV CDOGS_CLIENT_SECRET=${CDOGS_CLIENT_SECRET}
-ENV CDOGS_URL=${CDOGS_URL}
-ENV ACCESS_API_URL=${ACCESS_API_URL}
-ENV DOPS_URL=${DOPS_URL}
-ENV FRONTEND_URL=${FRONTEND_URL}
-ENV ORBC_SERVICE_ACCOUNT_CLIENT_ID=${ORBC_SERVICE_ACCOUNT_CLIENT_ID}
-ENV ORBC_SERVICE_ACCOUNT_AUDIENCE=${ORBC_SERVICE_ACCOUNT_AUDIENCE}
-
 # Copy production files from build
 COPY --from=builder /app/package*.json ./
 COPY --from=builder /app/node_modules ./node_modules

frontend/Dockerfile

@@ -3,22 +3,6 @@ FROM node:22.14.0-alpine AS builder
 #  Set the working directory to /app inside the container
 WORKDIR /app
 
-# Set variables
-#ENV NODE_ENV production
-ARG VITE_DEPLOY_ENVIRONMENT
-ARG VITE_API_VEHICLE_URL
-ARG VITE_POLICY_URL
-ARG VITE_KEYCLOAK_ISSUER_URL
-ARG VITE_KEYCLOAK_AUDIENCE
-ARG VITE_SITEMINDER_LOG_OFF_URL
-
-ENV VITE_DEPLOY_ENVIRONMENT=$VITE_DEPLOY_ENVIRONMENT
-ENV VITE_API_VEHICLE_URL=$VITE_API_VEHICLE_URL
-ENV VITE_POLICY_URL=$VITE_POLICY_URL
-ENV VITE_KEYCLOAK_ISSUER_URL=$VITE_KEYCLOAK_ISSUER_URL
-ENV VITE_KEYCLOAK_AUDIENCE=$VITE_KEYCLOAK_AUDIENCE
-ENV VITE_SITEMINDER_LOG_OFF_URL=$VITE_SITEMINDER_LOG_OFF_URL
-
 # Install app dependencies
 COPY ./package*.json ./
 

policy/Dockerfile

@@ -27,46 +27,6 @@ RUN mkdir /.npm && chmod 777 /.npm
 # Set the working directory to /app inside the deployment container
 WORKDIR /app
 
-# Set node to production
-ARG NODE_ENV
-ENV NODE_ENV=${NODE_ENV}
-
-
-ARG DB_TYPE
-ARG POLICY_API_LOG_LEVEL
-ARG POLICY_API_TYPEORM_LOG_LEVEL
-ARG POLICY_API_MAX_QUERY_EXECUTION_TIME_MS
-ARG POLICY_API_MSSQL_MAX_CONNECTION
-ARG MSSQL_HOST
-ARG MSSQL_PORT
-ARG MSSQL_DB
-ARG MSSQL_SA_USER
-ARG MSSQL_SA_PASSWORD
-ARG MSSQL_ENCRYPT
-ARG KEYCLOAK_ISSUER_URL
-ARG KEYCLOAK_AUDIENCE
-ARG KEYCLOAK_IGNORE_EXP
-ARG ORBC_SERVICE_ACCOUNT_CLIENT_ID
-ARG ORBC_SERVICE_ACCOUNT_AUDIENCE
-
-# Set environment variables
-ENV DB_TYPE=${DB_TYPE}
-ENV POLICY_API_LOG_LEVEL=${POLICY_API_LOG_LEVEL}
-ENV POLICY_API_TYPEORM_LOG_LEVEL=${POLICY_API_TYPEORM_LOG_LEVEL}
-ENV POLICY_API_MAX_QUERY_EXECUTION_TIME_MS=${POLICY_API_MAX_QUERY_EXECUTION_TIME_MS}
-ENV POLICY_API_MSSQL_MAX_CONNECTION=${POLICY_API_MSSQL_MAX_CONNECTION}
-ENV MSSQL_HOST=${MSSQL_HOST}
-ENV MSSQL_PORT=${MSSQL_PORT}
-ENV MSSQL_DB=${MSSQL_DB}
-ENV MSSQL_SA_USER=${MSSQL_SA_USER}
-ENV MSSQL_SA_PASSWORD=${MSSQL_SA_PASSWORD}
-ENV MSSQL_ENCRYPT=${MSSQL_ENCRYPT}
-ENV KEYCLOAK_ISSUER_URL=${KEYCLOAK_ISSUER_URL}
-ENV KEYCLOAK_AUDIENCE=${KEYCLOAK_AUDIENCE}
-ENV KEYCLOAK_IGNORE_EXP=${KEYCLOAK_IGNORE_EXP}
-ENV ORBC_SERVICE_ACCOUNT_CLIENT_ID=${ORBC_SERVICE_ACCOUNT_CLIENT_ID}
-ENV ORBC_SERVICE_ACCOUNT_AUDIENCE=${ORBC_SERVICE_ACCOUNT_AUDIENCE}
-
 # Copy production files from build
 COPY --from=builder /app/package*.json ./
 COPY --from=builder /app/node_modules ./node_modules
@@ -84,4 +44,4 @@ USER node
 CMD ["npm", "run", "start:prod"]
 
 # Health check
-HEALTHCHECK --interval=30s --timeout=3s CMD curl -f http://localhost:5002/
+HEALTHCHECK --interval=30s --timeout=3s CMD curl -f http://localhost:5002/

scheduler/Dockerfile

@@ -27,88 +27,6 @@ RUN mkdir /.npm && chmod 777 /.npm
 # Set the working directory to /app inside the deployment container
 WORKDIR /app
 
-# Set node to production
-ARG NODE_ENV
-ENV NODE_ENV=${NODE_ENV}
-
-
-ARG DB_TYPE
-ARG SCHEDULER_API_LOG_LEVEL
-ARG SCHEDULER_API_TYPEORM_LOG_LEVEL
-ARG SCHEDULER_API_MAX_QUERY_EXECUTION_TIME_MS
-ARG SCHEDULER_API_MSSQL_MAX_CONNECTION
-ARG MSSQL_HOST
-ARG MSSQL_PORT
-ARG MSSQL_DB
-ARG MSSQL_SA_USER
-ARG MSSQL_SA_PASSWORD
-ARG MSSQL_ENCRYPT
-ARG KEYCLOAK_ISSUER_URL
-ARG KEYCLOAK_AUDIENCE
-ARG KEYCLOAK_IGNORE_EXP
-ARG OCIO_S3_ACCESSKEYID
-ARG OCIO_S3_BUCKET
-ARG OCIO_S3_PRESIGNED_URL_EXPIRY
-ARG OCIO_S3_ENDPOINT
-ARG OCIO_S3_KEY
-ARG OCIO_S3_SECRETACCESSKEY
-ARG TPS_POLL_LIMIT
-ARG TPS_PENDING_POLLING_INTERVAL
-ARG TPS_ERROR_POLLING_INTERVAL
-ARG TPS_MONITORING_POLLING_INTERVAL
-ARG CFS_PRIVATE_KEY
-ARG CFS_PRIVATE_KEY_PASSPHRASE
-ARG CFS_SFTP_USERNAME
-ARG CFS_SFTP_HOST
-ARG CFS_SFTP_PORT
-ARG CFS_REMOTE_PATH
-ARG ORBC_SERVICE_ACCOUNT_CLIENT_ID
-ARG ORBC_SERVICE_ACCOUNT_CLIENT_SECRET
-ARG ORBC_SERVICE_ACCOUNT_TOKEN_URL
-ARG ACCESS_API_URL
-ARG ISSUE_PERMIT_LIMIT
-ARG DOC_GEN_LIMIT
-ARG PERMIT_SCHEDULE_POLLING_INTERVAL
-
-# Set environment variables
-ENV DB_TYPE=${DB_TYPE}
-ENV SCHEDULER_API_LOG_LEVEL=${SCHEDULER_API_LOG_LEVEL}
-ENV SCHEDULER_API_TYPEORM_LOG_LEVEL=${SCHEDULER_API_TYPEORM_LOG_LEVEL}
-ENV SCHEDULER_API_MAX_QUERY_EXECUTION_TIME_MS=${SCHEDULER_API_MAX_QUERY_EXECUTION_TIME_MS}
-ENV SCHEDULER_API_MSSQL_MAX_CONNECTION=${SCHEDULER_API_MSSQL_MAX_CONNECTION}
-ENV MSSQL_HOST=${MSSQL_HOST}
-ENV MSSQL_PORT=${MSSQL_PORT}
-ENV MSSQL_DB=${MSSQL_DB}
-ENV MSSQL_SA_USER=${MSSQL_SA_USER}
-ENV MSSQL_SA_PASSWORD=${MSSQL_SA_PASSWORD}
-ENV MSSQL_ENCRYPT=${MSSQL_ENCRYPT}
-ENV KEYCLOAK_ISSUER_URL=${KEYCLOAK_ISSUER_URL}
-ENV KEYCLOAK_AUDIENCE=${KEYCLOAK_AUDIENCE}
-ENV KEYCLOAK_IGNORE_EXP=${KEYCLOAK_IGNORE_EXP}
-ENV OCIO_S3_ACCESSKEYID=${OCIO_S3_ACCESSKEYID}
-ENV OCIO_S3_BUCKET=${OCIO_S3_BUCKET}
-ENV OCIO_S3_PRESIGNED_URL_EXPIRY=${OCIO_S3_PRESIGNED_URL_EXPIRY}
-ENV OCIO_S3_ENDPOINT=${OCIO_S3_ENDPOINT}
-ENV OCIO_S3_KEY=${OCIO_S3_KEY}
-ENV OCIO_S3_SECRETACCESSKEY=${OCIO_S3_SECRETACCESSKEY}
-ENV TPS_POLL_LIMIT=${TPS_POLL_LIMIT}
-ENV TPS_PENDING_POLLING_INTERVAL=${TPS_PENDING_POLLING_INTERVAL}
-ENV TPS_ERROR_POLLING_INTERVAL=${TPS_ERROR_POLLING_INTERVAL}
-ENV TPS_MONITORING_POLLING_INTERVAL=${TPS_MONITORING_POLLING_INTERVAL}
-ENV CFS_PRIVATE_KEY=${CFS_PRIVATE_KEY}
-ENV CFS_PRIVATE_KEY_PASSPHRASE=${CFS_PRIVATE_KEY_PASSPHRASE}
-ENV CFS_SFTP_USERNAME=${CFS_SFTP_USERNAME}
-ENV CFS_SFTP_HOST=${CFS_SFTP_HOST}
-ENV CFS_SFTP_PORT=${CFS_SFTP_PORT}
-ENV CFS_REMOTE_PATH=${CFS_REMOTE_PATH}
-ENV ORBC_SERVICE_ACCOUNT_CLIENT_ID=${ORBC_SERVICE_ACCOUNT_CLIENT_ID}
-ENV ORBC_SERVICE_ACCOUNT_CLIENT_SECRET=${ORBC_SERVICE_ACCOUNT_CLIENT_SECRET}
-ENV ORBC_SERVICE_ACCOUNT_TOKEN_URL=${ORBC_SERVICE_ACCOUNT_TOKEN_URL}
-ENV ACCESS_API_URL=${ACCESS_API_URL}
-ENV ISSUE_PERMIT_LIMIT=${ISSUE_PERMIT_LIMIT}
-ENV DOC_GEN_LIMIT=${DOC_GEN_LIMIT}
-ENV PERMIT_SCHEDULE_POLLING_INTERVAL=${PERMIT_SCHEDULE_POLLING_INTERVAL}
-
 # Copy production files from build
 COPY --from=builder /app/package*.json ./
 COPY --from=builder /app/node_modules ./node_modules

vehicles/Dockerfile

@@ -27,69 +27,6 @@ RUN mkdir /.npm && chmod 777 /.npm
 # Set the working directory to /app inside the deployment container
 WORKDIR /app
 
-# Set node to production
-ARG NODE_ENV
-ENV NODE_ENV=${NODE_ENV}
-
-
-ARG DB_TYPE
-ARG VEHICLES_API_LOG_LEVEL
-ARG VEHICLES_API_TYPEORM_LOG_LEVEL
-ARG VEHICLES_API_MAX_QUERY_EXECUTION_TIME_MS
-ARG VEHICLES_API_MSSQL_MAX_CONNECTION
-ARG MSSQL_HOST
-ARG MSSQL_PORT
-ARG MSSQL_DB
-ARG MSSQL_SA_USER
-ARG MSSQL_SA_PASSWORD
-ARG MSSQL_ENCRYPT
-ARG KEYCLOAK_ISSUER_URL
-ARG KEYCLOAK_AUDIENCE
-ARG KEYCLOAK_IGNORE_EXP
-ARG ACCESS_API_URL
-ARG DOPS_URL
-ARG FRONTEND_URL
-ARG PAYBC_API_KEY
-ARG PAYBC_REF_NUMBER
-ARG PAYBC_BASE_URL
-ARG GL_CODE
-ARG PAYBC_REDIRECT
-ARG ORBC_SERVICE_ACCOUNT_CLIENT_ID
-ARG ORBC_SERVICE_ACCOUNT_AUDIENCE
-ARG CFS_CREDIT_ACCOUNT_URL
-ARG CFS_CREDIT_ACCOUNT_CLIENT_ID
-ARG CFS_CREDIT_ACCOUNT_CLIENT_SECRET
-ARG BCGOV_FAX_EMAIL
-# Set environment variables
-ENV DB_TYPE=${DB_TYPE}
-ENV VEHICLES_API_LOG_LEVEL=${VEHICLES_API_LOG_LEVEL}
-ENV VEHICLES_API_TYPEORM_LOG_LEVEL=${VEHICLES_API_TYPEORM_LOG_LEVEL}
-ENV VEHICLES_API_MAX_QUERY_EXECUTION_TIME_MS=${VEHICLES_API_MAX_QUERY_EXECUTION_TIME_MS}
-ENV VEHICLES_API_MSSQL_MAX_CONNECTION=${VEHICLES_API_MSSQL_MAX_CONNECTION}
-ENV MSSQL_HOST=${MSSQL_HOST}
-ENV MSSQL_PORT=${MSSQL_PORT}
-ENV MSSQL_DB=${MSSQL_DB}
-ENV MSSQL_SA_USER=${MSSQL_SA_USER}
-ENV MSSQL_SA_PASSWORD=${MSSQL_SA_PASSWORD}
-ENV MSSQL_ENCRYPT=${MSSQL_ENCRYPT}
-ENV KEYCLOAK_ISSUER_URL=${KEYCLOAK_ISSUER_URL}
-ENV KEYCLOAK_AUDIENCE=${KEYCLOAK_AUDIENCE}
-ENV KEYCLOAK_IGNORE_EXP=${KEYCLOAK_IGNORE_EXP}
-ENV ACCESS_API_URL=${ACCESS_API_URL}
-ENV DOPS_URL=${DOPS_URL}
-ENV FRONTEND_URL=${FRONTEND_URL}
-ENV PAYBC_API_KEY=${PAYBC_API_KEY}
-ENV PAYBC_REF_NUMBER=${PAYBC_REF_NUMBER}
-ENV PAYBC_BASE_URL=${PAYBC_BASE_URL}
-ENV GL_CODE=${GL_CODE}
-ENV PAYBC_REDIRECT=${PAYBC_REDIRECT}
-ENV ORBC_SERVICE_ACCOUNT_CLIENT_ID=${ORBC_SERVICE_ACCOUNT_CLIENT_ID}
-ENV ORBC_SERVICE_ACCOUNT_AUDIENCE=${ORBC_SERVICE_ACCOUNT_AUDIENCE}
-ENV CFS_CREDIT_ACCOUNT_URL=${CFS_CREDIT_ACCOUNT_URL}
-ENV CFS_CREDIT_ACCOUNT_CLIENT_ID=${CFS_CREDIT_ACCOUNT_CLIENT_ID}
-ENV CFS_CREDIT_ACCOUNT_CLIENT_SECRET=${CFS_CREDIT_ACCOUNT_CLIENT_SECRET}
-ENV BCGOV_FAX_EMAIL=${BCGOV_FAX_EMAIL}
-
 # Copy production files from build
 COPY --from=builder /app/package*.json ./
 COPY --from=builder /app/node_modules ./node_modules