ORV2-3151 ORV2-3379 ORV2-3380 Remove date range limit for Payment and Refund Summary report (#1821)

Author: praju-aot

frontend/src/features/idir/reporting/forms/PaymentAndRefundDetail.tsx

@@ -249,7 +249,7 @@ export const PaymentAndRefundDetail = () => {
                 </Stack>
               )}
               <Stack direction="row" spacing={3}>
-                <ReportDateTimePickers />
+                <ReportDateTimePickers enableDateRangeValidation={true}/>
               </Stack>
               <br />
               <Stack direction="row">

frontend/src/features/idir/reporting/forms/subcomponents/ReportDateTimePickers.tsx

@@ -6,17 +6,26 @@ import duration from "dayjs/plugin/duration";
 import { useFormContext } from "react-hook-form";
 
 import { useCallback, useEffect } from "react";
-import { RequiredOrNull } from "../../../../../common/types/common";
+import { Optional, RequiredOrNull } from "../../../../../common/types/common";
 import { PaymentAndRefundSummaryFormData } from "../../types/types";
 
 dayjs.extend(duration);
 const THIRTY_ONE_DAYS = 31;
 const roundingBuffer = dayjs.duration(1, "hour").asDays();
 
+/**
+ * The props used by the ReportDateTimePickers component.
+ */
+export type ReportDateTimePickersProps = {
+  enableDateRangeValidation?: Optional<boolean>;
+};
+
 /**
  * The date time pickers for reports.
  */
-export const ReportDateTimePickers = () => {
+export const ReportDateTimePickers = ({
+  enableDateRangeValidation = false,
+}: ReportDateTimePickersProps) => {
   const { setValue, watch, setError, formState, clearErrors } =
     useFormContext<PaymentAndRefundSummaryFormData>();
   const { errors } = formState;
@@ -42,8 +51,10 @@ export const ReportDateTimePickers = () => {
   }, [fromDateTime, toDateTime]);
 
   useEffect(() => {
-    validateToDateTime();
-  }, [fromDateTime, toDateTime]);
+    if (enableDateRangeValidation) {
+      validateToDateTime();
+    }
+  }, [fromDateTime, toDateTime, enableDateRangeValidation]);
 
   return (
     <>
@@ -114,8 +125,14 @@ export const ReportDateTimePickers = () => {
              * The reports API account for a rounding value which allows this buffer.
              *
              * Hence the decision to add 1 minute to 30 days, to make life easier for user.
+             * 
+             * Note: Date range validation is not applicable for Summary Reports.
              */
-            maxDateTime={fromDateTime.add(THIRTY_ONE_DAYS, "days").add(1, "minute")}
+            maxDateTime={
+              enableDateRangeValidation
+                ? fromDateTime.add(THIRTY_ONE_DAYS, "days").add(1, "minute")
+                : undefined
+            }
             views={["year", "month", "day", "hours", "minutes"]}
             slotProps={{
               textField: {

vehicles/src/modules/permit-application-payment/payment/dto/request/create-payment-summary-report.dto.ts

@@ -29,20 +29,8 @@ export class CreatePaymentSummaryReportDto {
   @ApiProperty({
     example: '2023-10-27T23:26:51.170Z',
     description:
-      'Include records in the report till the given date and time.' +
-      'The difference between fromDateTime and toDateTime must not be' +
-      ' more than 31 days.',
+      'Include records in the report till the given date and time.'
   })
   @IsDateString()
-  @IsDateTimeAfter<CreatePaymentSummaryReportDto>('fromDateTime', {
-    difference: {
-      maxDiff: 31,
-      unit: 'days',
-    },
-    rounding: {
-      maxDiff: 1,
-      unit: 'hour',
-    },
-  })
   toDateTime: string;
 }