Rename to hashKey

Author: TayGov

src/bambora-payment-starter/src/main/java/ca/bc/gov/open/bambora/payment/starter/BamboraProperties.java

@@ -11,7 +11,7 @@ public class BamboraProperties {
     private String merchantId;
     private String hostedProfileUrl;
     private String hostedProfileServiceVersion;
-    private String key;
+    private String hashKey;
     private int minutesToExpiry;
 
     public String getMerchantId() {
@@ -38,12 +38,12 @@ public void setHostedProfileServiceVersion(String hostedProfileServiceVersion) {
         this.hostedProfileServiceVersion = hostedProfileServiceVersion;
     }
 
-    public String getKey() {
-        return key;
+    public String getHashKey() {
+        return hashKey;
     }
 
-    public void setKey(String key) {
-        this.key = key;
+    public void setHashKey(String hashKey) {
+        this.hashKey = hashKey;
     }
 
     public int getMinutesToExpiry() {

src/bambora-payment-starter/src/main/java/ca/bc/gov/open/bambora/payment/starter/managment/BamboraCardServiceImpl.java

@@ -55,7 +55,7 @@ private Uri buildRecurringPaymentUrl(RecurringPaymentDetails recurringPaymentDet
             paramString.append(formatBamboraParam("&", BamboraConstants.PARAM_PPRDIR_CUSTOMER_CODE, recurringPaymentDetails.getEndUserId()));
 
         //add hash key at end of params
-        paramString.append(bamboraProperties.getKey());
+        paramString.append(bamboraProperties.getHashKey());
 
         String hashed = getHash(paramString.toString());
 
@@ -67,7 +67,7 @@ private Uri buildRecurringPaymentUrl(RecurringPaymentDetails recurringPaymentDet
         String expiry = sdfDate.format(cal.getTime());
 
         // Add hash and expiry to the redirect
-        String hashedParameter = paramString.toString().replace(bamboraProperties.getKey(), MessageFormat.format("&{0}={1}&{2}={3}",  BamboraConstants.PARAM_TRANS_HASH_VALUE, hashed, BamboraConstants.PARAM_TRANS_HASH_EXPIRY, expiry));
+        String hashedParameter = paramString.toString().replace(bamboraProperties.getHashKey(), MessageFormat.format("&{0}={1}&{2}={3}",  BamboraConstants.PARAM_TRANS_HASH_VALUE, hashed, BamboraConstants.PARAM_TRANS_HASH_EXPIRY, expiry));
 
         return new Uri(MessageFormat.format("{0}?{1}", bamboraProperties.getHostedProfileUrl(), hashedParameter));
 

src/bambora-payment-starter/src/test/java/ca/bc/gov/open/bambora/payment/starter/managment/BamboraCardServiceImplTest.java

@@ -31,7 +31,7 @@ public void init() {
         bamboraProperties = new BamboraProperties();
         bamboraProperties.setHostedProfileServiceVersion(PROFILE_SERVICE_VERSION);
         bamboraProperties.setHostedProfileUrl(HOSTED_PROFILE_URL);
-        bamboraProperties.setKey(KEY);
+        bamboraProperties.setHashKey(KEY);
         bamboraProperties.setMerchantId(MERCHANT_ID);
         bamboraProperties.setMinutesToExpiry(MINUTES_TO_EXPIRY);