Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with npx #93

Closed
zloirock opened this issue Nov 4, 2022 · 12 comments
Closed

Make it work with npx #93

zloirock opened this issue Nov 4, 2022 · 12 comments

Comments

@zloirock
Copy link

zloirock commented Nov 4, 2022

Original issue: mysticatea/npm-run-all#209

@bcomnes
Copy link
Owner

bcomnes commented Nov 4, 2022

Probably should fix this. Anyone attempt patches upstream I can pull in?

@zloirock
Copy link
Author

zloirock commented Nov 5, 2022

@bcomnes
Copy link
Owner

bcomnes commented Nov 5, 2022

Cool ty. I'll look at getting that merged and tested.

@bcomnes
Copy link
Owner

bcomnes commented Nov 8, 2022

@MarmadileManteater That would be great and I appreciate it!

@bcomnes
Copy link
Owner

bcomnes commented Nov 9, 2022

https://github.com/bcomnes/npm-run-all2/releases/tag/v6.0.3

Reopen if there are issue

@bcomnes bcomnes closed this as completed Nov 9, 2022
@zloirock
Copy link
Author

zloirock commented Nov 9, 2022

It seems it's still not fixed

image

@MarmadileManteater

@bcomnes bcomnes reopened this Nov 9, 2022
@bcomnes
Copy link
Owner

bcomnes commented Nov 9, 2022

@zloirock you are right this didn't quite work out.

@MarmadileManteater Can you provide more information on the following env vars you referenced in your patch?

  • process.env.NPM_CLI_JS
  • rocess.env.npm_config_user_agent

Are these standard or set by a tool somewhere or did you expect people to have to set these?

@bcomnes
Copy link
Owner

bcomnes commented Nov 9, 2022

@MarmadileManteater #96

@bcomnes
Copy link
Owner

bcomnes commented Nov 9, 2022

This could be addressed by looking for npm_cli.js in the same directory that npx_cli.js is in since npm_execpath seems to exist on all systems.

Great minds think alike!

@zloirock
Copy link
Author

zloirock commented Nov 9, 2022

Yep, at debugging I see:

options.npmPath: null
process.env.NPM_CLI_JS: undefined
process.env.npm_execpath: /usr/local/lib/node_modules/npm/bin/npx-cli.js
npmPath: /usr/local/lib/node_modules/npm/bin/npx-cli.js
npmPathIsJs: true
execPath: /usr/local/bin/node

so #96 looks like a proper fix.

@bcomnes
Copy link
Owner

bcomnes commented Nov 9, 2022

Ok everyone give https://github.com/bcomnes/npm-run-all2/releases/tag/v6.0.4 a whirl.

@bcomnes bcomnes closed this as completed Nov 9, 2022
@zloirock
Copy link
Author

zloirock commented Nov 9, 2022

It works for me, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants