Skip to content

Commit cd9364c

Browse files
mmacura311sopos
authored andcommitted
Remove post-upgrade cleanup phase in tmt_upgrade mode
After user feedback it was decided to disable the post-upgrade cleanup phase again. This commit also updates the build-in documentation in a docstring at the beginning of the library.
1 parent c4e308a commit cd9364c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

mcase/lib.sh

+5-2
Original file line numberDiff line numberDiff line change
@@ -976,7 +976,6 @@ __distribution_mcase__w_tmt_upgrade() {
976976
elif test "$IN_PLACE_UPGRADE" == "new"; then
977977
echo test
978978
echo diag
979-
echo cleanup
980979
else
981980
__distribution_mcase__error "invalid tmt_upgrade call; stage not applicable"
982981
fi
@@ -1186,8 +1185,12 @@ to one of following values:
11861185
will consult IN_PLACE_UPGRADE to decide which handlers to run.
11871186
11881187
Normally this will mean `setup`, `test`, `diag` if the value of
1189-
IN_PLACE_UPGRADE variable is `old`, and `test`, `diag` and `cleanup`
1188+
IN_PLACE_UPGRADE variable is `old`, and `test` and `diag`
11901189
if the value is `new` (upgraded distro).
1190+
'Cleanup' phase of the test is not executed post-upgrade. If the test
1191+
relies on beakerlib functions to preserve states using eg
1192+
rlServiceStart/rlServiceRestore or rlFileBackup/rlFileRestore
1193+
those are not available after reboot, which causes the test to fail.
11911194
11921195
11931196
=head1 PERSISTENCE AND WORKING DIRECTORY

0 commit comments

Comments
 (0)