user error stack, optional params #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, users of bearcat-dao get an error from mysql-lib, but don't know what of there code coursed that error.
in our team, we had a few times the problem, that the developer want to execute a specific query, that is not using any parameter. now it is necessary to pass an empty object or array to the methods. (mostly get list) but they will not receive a Bearcat object, but directly the mySQL result. it will also course that the used mySQL-connection will not get released to the pool. (is locket forever)
|
is this project no longer maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in dimainDaoSupport, to allow params as optional parameter. if params is not passed the result was directly the mysql result-list and the connection was not returned to the pool
second is for debugging.
when there is an error, if was impossible to see where the error came from in the users project.
the error-stack has only shown from mysql-getConnection over pomelo to mysql query.
now it will also provide information, where the user of Bearcat dao has triggered the query.
Both changes are not breaking any API and are fully compatible with existing projects