Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the doc about the way to reference third-party packages in monorepo.json is wrong #31

Open
stof opened this issue May 30, 2016 · 3 comments

Comments

@stof
Copy link

stof commented May 30, 2016

It says that you should use the path relative to the root of the repo, but this is wrong. the actual expectation is to use 'vendor/'.$composerPackageName:

$name = $composerJson['name'];

While this matches the composer default installation path, there might be many reasons to have a different path:

  • using a different name for the vendor dir
  • using the target-path property in the package
  • using a custom installer generating a different path
@stof
Copy link
Author

stof commented May 30, 2016

Btw, the MonorepoInstaller class actually expects the name to be the installation path for all packages, which means that the plugin is probably incompatible with use cases mentioned above.

@beberlei
Copy link
Owner

beberlei commented Jun 1, 2016

Isn't vendor/symfony/symfony relative to the root of the repo? That at least what i mean here.

Currently only working with the default vendor/ is supported.

@stof
Copy link
Author

stof commented Jun 2, 2016

@beberlei half of the code expects the installation path, and half of the code expects 'vendor/'.$composerPackageName (which might be the same, but might be totally different).
In the case of symfony, it is indeed the same, because it does not match any of the conditions I listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants