Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search limit has a default of 25 even if no search limit attribute is set, and function on span tag is frustrating #78

Open
mmestas opened this issue Jun 11, 2021 · 1 comment

Comments

@mmestas
Copy link

mmestas commented Jun 11, 2021

b.searchLimit||25

The multiselect seems to default to a dropdown list of only the first 25 results unless the attribute, search-limit, is set - regardless of whether or not show-search was being used. I had not added the search option, yet my list was only displaying 25 items. When I added the attribute, search-limit="1000" or some other high number, only then did I see all my results.

It's odd that it defaults to 25 without having the search or any other options set anywhere. The default should preferably be ceiling.

Another issue is that the select function, toggleItem(), is set on the span tag, instead of the li. This means that if someone tries selecting the item sightly outside on the li where the padding is, the selection cannot be triggered. It would be nice if the library added the function to the li instead of the span tag.

@ljluestc
Copy link

b.searchLimit !== undefined ? b.searchLimit : <your_preferred_default_value>
<li @click="toggleItem(item)">{{ item.text }}</li>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants