Skip to content

Commit 3585515

Browse files
benwindingbenwinding
committed
Improve demos, with yarn workspaces 
1 parent 7d8592b commit 3585515

12 files changed

+92
-83
lines changed

‎README.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[![License](https://img.shields.io/npm/l/quill-html-edit-button.svg)](https://github.com/benwinding/quill-html-edit-button/blob/master/LICENSE)
77
[![Downloads/week](https://img.shields.io/npm/dm/quill-html-edit-button.svg)](https://www.npmjs.com/package/quill-html-edit-button)
88
[![Github Issues](https://img.shields.io/github/issues/benwinding/quill-html-edit-button.svg)](https://github.com/benwinding/quill-html-edit-button)
9+
![Build and Publish](https://github.com/benwinding/quill-html-edit-button/actions/workflows/deploy.yml/badge.svg)
910

1011
<!-- [END badges] -->
1112

‎demos/build.sh

+16-27
Original file line numberDiff line numberDiff line change
@@ -9,36 +9,25 @@ cp ./header-text.js ./dist
99
cp ./demos-index.html ./dist/index.html
1010

1111
# Build typescript
12-
cd typescript
13-
rm -rf ./dist
14-
yarn && yarn build
15-
cp -r ./dist ../dist/typescript
16-
cd ..
12+
rm -rf ./typescript/dist
13+
yarn build:typescript
14+
cp -r ./typescript/dist ./dist/typescript
1715

1816
# Build javascript
19-
cd javascript
20-
rm -rf ./dist
21-
yarn && yarn build
22-
cp -r ./dist ../dist/javascript
23-
cd ..
17+
rm -rf ./javascript/dist
18+
yarn build:javascript
19+
cp -r ./javascript/dist ./dist/javascript
2420

25-
# Build script tags
26-
cd script-tags
27-
rm -rf ./dist
28-
mkdir ../dist/script-tags
29-
cp -r ./* ../dist/script-tags
30-
cd ..
21+
# Copy script tags
22+
mkdir ./dist/script-tags
23+
cp ./script-tags/* ./dist/script-tags
3124

3225
# Build vue
33-
cd vue
34-
rm -rf ./dist
35-
yarn && yarn build
36-
cp -r ./dist ../dist/vue
37-
cd ..
26+
rm -rf ./vue/dist
27+
yarn build:vue
28+
cp -r ./vue/dist ./dist/vue
3829

39-
# Build vue
40-
cd react
41-
rm -rf ./dist
42-
yarn && yarn build
43-
cp -r ./dist ../dist/react
44-
cd ..
30+
# Build react
31+
rm -rf ./react/dist
32+
yarn build:react
33+
cp -r ./react/dist ./dist/react

‎demos/javascript/package.json

+1-7
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"license": "MIT",
77
"scripts": {
88
"start": "webpack serve --mode development --hot",
9-
"build": "webpack"
10-
},
11-
"devDependencies": {
12-
"terser-webpack-plugin": "1.4.5",
13-
"webpack": "5.89.0",
14-
"webpack-cli": "4.10.0",
15-
"webpack-dev-server": "4.15.1"
9+
"build": "webpack --mode production"
1610
}
1711
}

‎demos/javascript/webpack.config.js

+9-8
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const CopyWebpackPlugin = require("copy-webpack-plugin");
44

55
const isProd = process.argv.includes("production");
66

7+
/**
8+
* @type {import('webpack').Configuration}
9+
*/
710
module.exports = {
811
entry: {
912
index: "./src/index.js",
@@ -24,23 +27,21 @@ module.exports = {
2427
},
2528
},
2629
plugins: [
27-
new CopyWebpackPlugin([
28-
{ from: "public", to: "." },
29-
{ from: "../header-text.js", to: "." },
30-
]),
30+
new CopyWebpackPlugin({
31+
patterns: [
32+
{ from: "public", to: "." },
33+
{ from: "../header-text.js", to: "." },
34+
],
35+
}),
3136
],
3237
devtool: isProd ? "source-map" : "inline-source-map",
3338
optimization: {
3439
minimize: true,
3540
minimizer: [
3641
new TerserPlugin({
3742
extractComments: true,
38-
cache: true,
3943
parallel: true,
40-
sourceMap: true, // Must be set to true if using source-maps in production
4144
terserOptions: {
42-
// https://github.com/webpack-contrib/terser-webpack-plugin#terseroptions
43-
extractComments: "all",
4445
compress: {
4546
drop_console: false,
4647
},

‎demos/package.json

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
{
2+
"name": "quill-html-edit-button-demos",
3+
"version": "0.0.1",
4+
"private": true,
5+
"workspaces": [
6+
"javascript",
7+
"react",
8+
"typescript",
9+
"vue"
10+
],
11+
"scripts": {
12+
"start:javascript": "yarn workspace javascript start",
13+
"start:react": "yarn workspace react start",
14+
"start:typescript": "yarn workspace typescript start",
15+
"start:vue": "yarn workspace vue start",
16+
"build:javascript": "yarn workspace javascript build",
17+
"build:react": "yarn workspace react build",
18+
"build:typescript": "yarn workspace typescript build",
19+
"build:vue": "yarn workspace vue build",
20+
"build": "./build.sh"
21+
},
22+
"devDependencies": {
23+
"babel-core": "^6.26.0",
24+
"babel-loader": "^7.1.3",
25+
"copy-webpack-plugin": "^12.0.2",
26+
"webpack": "5.89.0",
27+
"webpack-cli": "4.10.0",
28+
"webpack-dev-server": "4.15.1"
29+
}
30+
}

‎demos/react/package.json

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "javascript",
2+
"name": "react",
33
"private": true,
44
"version": "1.0.0",
55
"main": "index.js",
@@ -12,10 +12,8 @@
1212
"react-quill": "2.0.0",
1313
"react": "18.2.0",
1414
"react-dom": "18.2.0",
15+
"babel-core": "^6.26.0",
1516
"babel-loader": "9.1.3",
16-
"@babel/preset-react": "7.23.3",
17-
"webpack": "5.89.0",
18-
"webpack-cli": "4.10.0",
19-
"webpack-dev-server": "4.15.1"
17+
"@babel/preset-react": "7.23.3"
2018
}
2119
}

‎demos/react/webpack.config.js

+10-5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const CopyWebpackPlugin = require("copy-webpack-plugin");
44

55
const isProd = process.argv.includes("production");
66

7+
/**
8+
* @type {import('webpack').Configuration}
9+
*/
710
module.exports = {
811
entry: {
912
index: "./src/index.jsx",
@@ -20,11 +23,13 @@ module.exports = {
2023
writeToDisk: true,
2124
},
2225
},
23-
plugins: [
24-
new CopyWebpackPlugin([
25-
{ from: "public", to: "." },
26-
{ from: "../header-text.js", to: "." },
27-
]),
26+
plugins: [
27+
new CopyWebpackPlugin({
28+
patterns: [
29+
{ from: "public", to: "." },
30+
{ from: "../header-text.js", to: "." },
31+
],
32+
}),
2833
],
2934
devtool: isProd ? "source-map" : "inline-source-map",
3035
optimization: {

‎demos/typescript/package.json

+1-7
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"license": "MIT",
77
"scripts": {
88
"start": "webpack serve --mode development --hot",
9-
"build": "webpack"
10-
},
11-
"devDependencies": {
12-
"terser-webpack-plugin": "1.4.5",
13-
"webpack": "5.89.0",
14-
"webpack-cli": "4.10.0",
15-
"webpack-dev-server": "4.15.1"
9+
"build": "webpack --mode production"
1610
}
1711
}

‎demos/typescript/tsconfig.json

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"moduleResolution": "node",
1111
"allowSyntheticDefaultImports": true,
1212
"esModuleInterop": true,
13+
"skipLibCheck": true,
1314
"outDir": "dist",
1415
"lib": ["es2017", "dom"]
1516
},

‎demos/typescript/webpack.config.js

+9-15
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const CopyWebpackPlugin = require("copy-webpack-plugin");
44

55
const isProd = process.argv.includes("production");
66

7+
/**
8+
* @type {import('webpack').Configuration}
9+
*/
710
module.exports = {
811
entry: {
912
index: "./src/index.ts",
@@ -21,23 +24,21 @@ module.exports = {
2124
},
2225
},
2326
plugins: [
24-
new CopyWebpackPlugin([
25-
{ from: "public", to: "." },
26-
{ from: "../header-text.js", to: "." },
27-
]),
27+
new CopyWebpackPlugin({
28+
patterns: [
29+
{ from: "public", to: "." },
30+
{ from: "../header-text.js", to: "." },
31+
],
32+
}),
2833
],
2934
devtool: isProd ? "source-map" : "inline-source-map",
3035
optimization: {
3136
minimize: true,
3237
minimizer: [
3338
new TerserPlugin({
3439
extractComments: true,
35-
cache: true,
3640
parallel: true,
37-
sourceMap: true, // Must be set to true if using source-maps in production
3841
terserOptions: {
39-
// https://github.com/webpack-contrib/terser-webpack-plugin#terseroptions
40-
extractComments: "all",
4142
compress: {
4243
drop_console: false,
4344
},
@@ -55,13 +56,6 @@ module.exports = {
5556
test: /\.css$/,
5657
use: ["style-loader", "css-loader"],
5758
},
58-
{
59-
test: /\.js$/,
60-
exclude: /node_modules/,
61-
use: {
62-
loader: "babel-loader",
63-
},
64-
},
6559
{
6660
test: /\.svg$/,
6761
use: [

‎demos/vue/package.json

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "javascript",
2+
"name": "vue",
33
"private": true,
44
"version": "1.0.0",
55
"main": "index.js",
@@ -12,9 +12,6 @@
1212
"@vueup/vue-quill": "1.0.0-beta.8",
1313
"vue": "3.3.7",
1414
"vue-loader": "17.3.1",
15-
"vue-template-compiler": "2.6.14",
16-
"webpack": "5.89.0",
17-
"webpack-cli": "4.10.0",
18-
"webpack-dev-server": "4.15.1"
15+
"vue-template-compiler": "2.6.14"
1916
}
2017
}

‎demos/vue/webpack.config.js

+9-4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ const { VueLoaderPlugin } = require("vue-loader");
55

66
const isProd = process.argv.includes("production");
77

8+
/**
9+
* @type {import('webpack').Configuration}
10+
*/
811
module.exports = {
912
entry: {
1013
index: "./src/index.js",
@@ -22,10 +25,12 @@ module.exports = {
2225
},
2326
},
2427
plugins: [
25-
new CopyWebpackPlugin([
26-
{ from: "public", to: "." },
27-
{ from: "../header-text.js", to: "." },
28-
]),
28+
new CopyWebpackPlugin({
29+
patterns: [
30+
{ from: "public", to: "." },
31+
{ from: "../header-text.js", to: "." },
32+
],
33+
}),
2934
new VueLoaderPlugin(),
3035
],
3136
devtool: isProd ? "source-map" : "inline-source-map",

0 commit comments

Comments
 (0)