Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help messages #2477

Open
camembera opened this issue Feb 4, 2025 · 2 comments
Open

Improve help messages #2477

camembera opened this issue Feb 4, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@camembera
Copy link
Contributor

camembera commented Feb 4, 2025

  1. The default help for beacond has this line as the first line of output:
    "A basic beacon node, usable most standard networks."
    maybe: "A beacon node, usable with most Ethereum execution clients"

  2. help deposit create-validator says: Creates a validator deposit with the necessary credentials. This suggests it transacts for you. The help further refers to a broadcast flag, which is not otherwise mentioned. Revise to clarify what this command now does, which is generate transaction parameters.

  3. deposit validate should produce some kind of message to indicate that the parameters check out. Right now the only hint everything's fine is if the exit status $? is 0

  4. deposit create-validator returns the amount as a hex string. If you then provide this hex string to deposit validate it is rejected. Either return decimal (preferred) or accept hex (misleading, because this is generally understood to represent bytes and not a hexademical encoding of a decimal number).

@camembera camembera added the enhancement New feature or request label Feb 4, 2025
@wonderfan
Copy link

Thanks for your feedback and let me refine them.

@wonderfan
Copy link

./build/bin/beacond 
A basic beacon node, modular and PoL chain usable with most Ethereum execution clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants