Skip to content

Commit 32bdfcd

Browse files
author
jantje
committed
externalize strings to fix warnings
1 parent 1c9de18 commit 32bdfcd

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

io.sloeber.core/src/io/sloeber/core/Messages.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ public class Messages extends NLS {
6363
public static String ArduinoSerial_Continuing_to_use;
6464
public static String ArduinoSerial_Ending_reset;
6565
public static String ArduinoSerial_exception_while_opening_seral_port;
66+
public static String ArduinoSerial_port_reappeared;
67+
public static String ArduinoSerial_port_still_missing;
6668

6769
public static String ArduinoSerial_reset_dtr_toggle;
6870
public static String ArduinoSerial_reset_failed;

io.sloeber.core/src/io/sloeber/core/communication/ArduinoSerial.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private static String wait_for_com_Port_to_appear(MessageConsoleStream console,
124124
} while (newPortsCopy.isEmpty());
125125

126126
console.println(
127-
Messages.ArduinoSerial_Comport_reset_took.replace("{ms}",Integer.toString(numTries * delayMs)));
127+
Messages.ArduinoSerial_Comport_reset_took.replace("{ms}",Integer.toString(numTries * delayMs))); //$NON-NLS-1$
128128
return newPortsCopy.get(0);
129129

130130
}
@@ -247,9 +247,9 @@ public static String makeArduinoUploadready(MessageConsoleStream console, IProje
247247
return newComport;
248248
}
249249
if (wait_for_com_Port_to_appear(comPort)) {
250-
console.println("comport {port} reappeared. continuing...".replace("{port}", comPort)); //$NON-NLS-2$
250+
console.println(Messages.ArduinoSerial_port_reappeared.replace("{port}", comPort)); //$NON-NLS-1$
251251
}else {
252-
console.println("comport {port} still not found. continuing..".replace("{port}", comPort)); //$NON-NLS-2$
252+
console.println(Messages.ArduinoSerial_port_still_missing.replace("{port}", comPort)); //$NON-NLS-1$
253253
}
254254

255255
}

io.sloeber.core/src/io/sloeber/core/messages.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ ArduinoSerial_Comport_reset_took=Com port reset took {ms} ms.
5757
ArduinoSerial_Continuing_to_use=Continuing to use : "{port}"
5858
ArduinoSerial_Ending_reset=Ending reset
5959
ArduinoSerial_exception_while_opening_seral_port=Exception while opening Serial port :
60+
ArduinoSerial_port_reappeared=comport {port} reappeared. continuing...
61+
ArduinoSerial_port_still_missing=comport {port} still not found. continuing..
6062
ArduinoSerial_reset_dtr_toggle=Starting reset using DTR toggle process
6163
ArduinoSerial_reset_failed=reset using 1200bps touch failed
6264
ArduinoSerial_Unable_To_Open_Port=Unable to open Serial port :

0 commit comments

Comments
 (0)