You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The best default behavior for loggers is to hand over to the user the responsibility of defining log handlers (see Python documentation).
f3dasm may be used as an application or as a library. A default logging behavior is suitable when f3dasm is used as an application (current implementation). However, this is not suitable when used as a library because the logging configuration may overlap / be in conflict with the logging configuration wished by the user.
Description
Commit 3cd4d1e proposes a more flexible framework where the existence of a logger is checked when initializing f3dasm. Then, if the user wishes to define his own logging configuration, he simply has to get a logger with f3dasm name before importing f3dasm. Otherwise, f3dasm loads the default behavior from a config file avoiding the use of the basicConfig() method.
The default behavior is similar to the existing implementation: logs are printed to stderr when level is above INFO. In addition, logs ares saved to a "f3dasm.log" file.
Motivation
@BernardoFerreira
The best default behavior for loggers is to hand over to the user the responsibility of defining log handlers (see Python documentation).
f3dasm may be used as an application or as a library. A default logging behavior is suitable when f3dasm is used as an application (current implementation). However, this is not suitable when used as a library because the logging configuration may overlap / be in conflict with the logging configuration wished by the user.
Description
Commit 3cd4d1e proposes a more flexible framework where the existence of a logger is checked when initializing f3dasm. Then, if the user wishes to define his own logging configuration, he simply has to get a logger with f3dasm name before importing f3dasm. Otherwise, f3dasm loads the default behavior from a config file avoiding the use of the
basicConfig()
method.The default behavior is similar to the existing implementation: logs are printed to stderr when level is above INFO. In addition, logs ares saved to a "f3dasm.log" file.
Behavior
Tasks
The text was updated successfully, but these errors were encountered: