Merge pull request #19 from lucasmichot/feature/dumper-useless-construct

mpociot · web-flow · commit 24ceaa856c82 · 2018-08-19T15:05:21.000+02:00
No need to declare a dumper so early.
diff --git a/src/Dumper.php b/src/Dumper.php
@@ -36,11 +36,10 @@ public function __construct(Connection $connection = null)
     public function dump($value)
     {
         if (class_exists(CliDumper::class)) {
-            $dumper = in_array(PHP_SAPI, ['cli', 'phpdbg']) ? new CliDumper : new HtmlDumper;
-
             $data = (new VarCloner)->cloneVar($value);
 
-            if (!$this->connection || !$this->connection->write($data)) {
+            if ($this->connection === null || $this->connection->write($data) === false) {
+                $dumper = in_array(PHP_SAPI, ['cli', 'phpdbg']) ? new CliDumper : new HtmlDumper;
                 $dumper->dump($data);
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,10 @@ public function __construct(Connection $connection = null)`
`36`	`36`	`public function dump($value)`
`37`	`37`	`{`
`38`	`38`	`if (class_exists(CliDumper::class)) {`
`39`		`- $dumper = in_array(PHP_SAPI, ['cli', 'phpdbg']) ? new CliDumper : new HtmlDumper;`
`40`		`-`
`41`	`39`	`$data = (new VarCloner)->cloneVar($value);`
`42`	`40`
`43`		`- if (!$this->connection \|\| !$this->connection->write($data)) {`
	`41`	`+ if ($this->connection === null \|\| $this->connection->write($data) === false) {`
	`42`	`+ $dumper = in_array(PHP_SAPI, ['cli', 'phpdbg']) ? new CliDumper : new HtmlDumper;`
`44`	`43`	`$dumper->dump($data);`
`45`	`44`	`}`
`46`	`45`	`} else {`