magento#39641 Replace loop variable name to correct the "cache" effect on subsequent calls on the same $product object

bhennesAdv · bhennesAdv · commit 80c0d08f375b · 2025-02-20T10:41:07.000+01:00
diff --git a/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php b/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php
@@ -552,8 +552,8 @@ public function getUsedProductIds($product)
     {
         if (!$product->hasData($this->_usedProductIds)) {
             $usedProductIds = [];
-            foreach ($this->getUsedProducts($product) as $product) {
-                $usedProductIds[] = $product->getId();
+            foreach ($this->getUsedProducts($product) as $childProduct) {
+                $usedProductIds[] = $childProduct->getId();
             }
             $product->setData($this->_usedProductIds, $usedProductIds);
         }

Original file line number	Diff line number	Diff line change
`@@ -552,8 +552,8 @@ public function getUsedProductIds($product)`
`552`	`552`	`{`
`553`	`553`	`if (!$product->hasData($this->_usedProductIds)) {`
`554`	`554`	`$usedProductIds = [];`
`555`		`- foreach ($this->getUsedProducts($product) as $product) {`
`556`		`- $usedProductIds[] = $product->getId();`
	`555`	`+ foreach ($this->getUsedProducts($product) as $childProduct) {`
	`556`	`+ $usedProductIds[] = $childProduct->getId();`
`557`	`557`	`}`
`558`	`558`	`$product->setData($this->_usedProductIds, $usedProductIds);`
`559`	`559`	`}`