Skip to content

Reduce the visibility of protected static methods #93

@alessandrodalbello

Description

@alessandrodalbello

The MoveList implementation contains a couple of protected static methods that depend on the thread-local reference of the board used as a support for the class itself. Honestly, I don't see any reason to expose the internals to sub-classes and other classes in the same package. I believe they could be "safely" converted to private methods and used only internally as support for the MoveList functionalities: existing integrations of the chesslib library should not make any usage of those methods unless they decided to extend MoveList and access statically a method of the super-class. Please, correct me here if there is a motivation to keep the access visibility as it is at the moment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions