Updated coverage thresholds (#23)

* Updated coverage thresholdholds * Fixed total calculation
bibipkins · Mar 2, 2023 · 619ac8c · 619ac8c
1 parent cb1fece
commit 619ac8c
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -43,7 +43,7 @@ jobs:
           comment-title: Test Coverage OpenCover
           results-path: ./files/success/
           coverage-path: ./files/success/test_coverage_opencover.xml
-          coverage-threshold: 46
+          coverage-threshold: 44
       - name: Test Coverage Cobertura
         uses: ./
         with:
@@ -52,4 +52,4 @@ jobs:
           results-path: ./files/success
           coverage-path: ./files/success/test_coverage_cobertura.xml
           coverage-type: cobertura
-          coverage-threshold: 46
+          coverage-threshold: 44
diff --git a/dist/index.js b/dist/index.js
@@ -290,7 +290,7 @@ const common_1 = __nccwpck_require__(9023);
 const parseCobertura = (filePath, threshold) => __awaiter(void 0, void 0, void 0, function* () { return (0, common_1.parseCoverage)(filePath, threshold, parseSummary, parseModules); });
 const parseSummary = (file) => {
     const summary = file.coverage['$'];
-    const totalCoverage = (0, common_1.calculateCoverage)(summary['lines-covered'] + summary['branches-covered'], summary['lines-valid'] + summary['branches-valid']);
+    const totalCoverage = (0, common_1.calculateCoverage)(Number(summary['lines-covered']) + Number(summary['branches-covered']), Number(summary['lines-valid']) + Number(summary['branches-valid']));
     return {
         totalCoverage,
         linesTotal: Number(summary['lines-valid']),
@@ -370,7 +370,7 @@ const calculateCoverage = (covered, total) => {
 exports.calculateCoverage = calculateCoverage;
 const createCoverageModule = (name, threshold, files) => {
     const total = files.reduce((summ, file) => summ + file.linesTotal + file.branchesTotal, 0);
-    const covered = files.reduce((summ, file) => summ + file.linesCovered + file.linesCovered, 0);
+    const covered = files.reduce((summ, file) => summ + file.linesCovered + file.branchesCovered, 0);
     const coverage = (0, exports.calculateCoverage)(covered, total);
     const success = !threshold || coverage >= threshold;
     const updatedFiles = files
@@ -413,7 +413,7 @@ const common_1 = __nccwpck_require__(9023);
 const parseOpencover = (filePath, threshold) => __awaiter(void 0, void 0, void 0, function* () { return (0, common_1.parseCoverage)(filePath, threshold, parseSummary, parseModules); });
 const parseSummary = (file) => {
     const summary = file.CoverageSession.Summary[0]['$'];
-    const totalCoverage = (0, common_1.calculateCoverage)(summary.visitedSequencePoints + summary.visitedBranchPoints, summary.numSequencePoints + summary.numBranchPoints);
+    const totalCoverage = (0, common_1.calculateCoverage)(Number(summary.visitedSequencePoints) + Number(summary.visitedBranchPoints), Number(summary.numSequencePoints) + Number(summary.numBranchPoints));
     return {
         totalCoverage,
         linesTotal: Number(summary.numSequencePoints),

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/parsers/cobertura.ts b/src/parsers/cobertura.ts
@@ -7,8 +7,8 @@ const parseCobertura: CoverageParser = async (filePath: string, threshold: numbe
 const parseSummary = (file: any): ICoverageData => {
   const summary = file.coverage['$'];
   const totalCoverage = calculateCoverage(
-    summary['lines-covered'] + summary['branches-covered'],
-    summary['lines-valid'] + summary['branches-valid']
+    Number(summary['lines-covered']) + Number(summary['branches-covered']),
+    Number(summary['lines-valid']) + Number(summary['branches-valid'])
   );
 
   return {

diff --git a/src/parsers/opencover.ts b/src/parsers/opencover.ts
@@ -7,8 +7,8 @@ const parseOpencover: CoverageParser = async (filePath: string, threshold: numbe
 const parseSummary = (file: any): ICoverageData => {
   const summary = file.CoverageSession.Summary[0]['$'];
   const totalCoverage = calculateCoverage(
-    summary.visitedSequencePoints + summary.visitedBranchPoints,
-    summary.numSequencePoints + summary.numBranchPoints
+    Number(summary.visitedSequencePoints) + Number(summary.visitedBranchPoints),
+    Number(summary.numSequencePoints) + Number(summary.numBranchPoints)
   );
 
   return {