diff --git a/front_end/elements/elementsTreeOutline.css b/front_end/elements/elementsTreeOutline.css index fe6b2b78cf..8a2094a2e7 100644 --- a/front_end/elements/elementsTreeOutline.css +++ b/front_end/elements/elementsTreeOutline.css @@ -174,9 +174,8 @@ } .CodeMirror { - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: rgba(0, 0, 0, .5) 3px 3px 4px; + outline: 1px solid rgb(66%, 66%, 66%) !important; background-color: white; } @@ -195,9 +194,8 @@ button, input, select { .editing { -webkit-user-select: text; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: rgba(0, 0, 0, .5) 3px 3px 4px; + outline: 1px solid rgb(66%, 66%, 66%) !important; background-color: white; -webkit-user-modify: read-write-plaintext-only; text-overflow: clip !important; diff --git a/front_end/main/Main.js b/front_end/main/Main.js index eb7fcc5d43..737d230ca0 100644 --- a/front_end/main/Main.js +++ b/front_end/main/Main.js @@ -303,7 +303,7 @@ WebInspector.Main.prototype = { InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ReloadInspectedPage, this._reloadInspectedPage, this); InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.EvaluateForTestInFrontend, this._evaluateForTestInFrontend, this); - this._mainTarget.runtimeAgent().run(); + this._mainTarget.runtimeAgent().runIfWaitingForDebugger(); if (this._mainTarget.hasBrowserCapability()) this._mainTarget.inspectorAgent().enable(); diff --git a/front_end/sdk/DebuggerModel.js b/front_end/sdk/DebuggerModel.js index 843f7eb8e3..9a8f771807 100644 --- a/front_end/sdk/DebuggerModel.js +++ b/front_end/sdk/DebuggerModel.js @@ -611,12 +611,12 @@ WebInspector.DebuggerModel.prototype = { * @param {string} code * @param {string} objectGroup * @param {boolean} includeCommandLineAPI - * @param {boolean} doNotPauseOnExceptionsAndMuteConsole + * @param {boolean} silent * @param {boolean} returnByValue * @param {boolean} generatePreview * @param {function(?WebInspector.RemoteObject, !RuntimeAgent.ExceptionDetails=)} callback */ - evaluateOnSelectedCallFrame: function(code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, callback) + evaluateOnSelectedCallFrame: function(code, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, callback) { /** * @param {?RuntimeAgent.RemoteObject} result @@ -631,7 +631,7 @@ WebInspector.DebuggerModel.prototype = { callback(this.target().runtimeModel.createRemoteObject(result), exceptionDetails); } - this.selectedCallFrame().evaluate(code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluate.bind(this)); + this.selectedCallFrame().evaluate(code, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, didEvaluate.bind(this)); }, /** @@ -1061,12 +1061,12 @@ WebInspector.DebuggerModel.CallFrame.prototype = { * @param {string} code * @param {string} objectGroup * @param {boolean} includeCommandLineAPI - * @param {boolean} doNotPauseOnExceptionsAndMuteConsole + * @param {boolean} silent * @param {boolean} returnByValue * @param {boolean} generatePreview * @param {function(?RuntimeAgent.RemoteObject, !RuntimeAgent.ExceptionDetails=)} callback */ - evaluate: function(code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, callback) + evaluate: function(code, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, callback) { /** * @param {?Protocol.Error} error @@ -1082,7 +1082,7 @@ WebInspector.DebuggerModel.CallFrame.prototype = { } callback(result, exceptionDetails); } - this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluateOnCallFrame); + this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, didEvaluateOnCallFrame); }, /** diff --git a/front_end/sdk/RemoteObject.js b/front_end/sdk/RemoteObject.js index cf61a22a5f..aa3765c0bf 100644 --- a/front_end/sdk/RemoteObject.js +++ b/front_end/sdk/RemoteObject.js @@ -656,7 +656,7 @@ WebInspector.RemoteObjectImpl.prototype = { return; } - this._runtimeAgent.invoke_evaluate({expression:value, doNotPauseOnExceptionsAndMuteConsole:true}, evaluatedCallback.bind(this)); + this._runtimeAgent.invoke_evaluate({expression:value, silent:true}, evaluatedCallback.bind(this)); /** * @param {?Protocol.Error} error diff --git a/front_end/sdk/RuntimeModel.js b/front_end/sdk/RuntimeModel.js index 86b44cd03d..b1b20e18ed 100644 --- a/front_end/sdk/RuntimeModel.js +++ b/front_end/sdk/RuntimeModel.js @@ -243,16 +243,16 @@ WebInspector.RuntimeModel.prototype = { * @param {!RuntimeAgent.ScriptId} scriptId * @param {number} executionContextId * @param {string=} objectGroup - * @param {boolean=} doNotPauseOnExceptionsAndMuteConsole + * @param {boolean=} silent * @param {boolean=} includeCommandLineAPI * @param {boolean=} returnByValue * @param {boolean=} generatePreview * @param {boolean=} awaitPromise * @param {function(?RuntimeAgent.RemoteObject, ?RuntimeAgent.ExceptionDetails=)=} callback */ - runScript: function(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, callback) + runScript: function(scriptId, executionContextId, objectGroup, silent, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, callback) { - this._agent.runScript(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, innerCallback); + this._agent.runScript(scriptId, executionContextId, objectGroup, silent, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, innerCallback); /** * @param {?Protocol.Error} error @@ -547,17 +547,17 @@ WebInspector.ExecutionContext.prototype = { * @param {string} expression * @param {string} objectGroup * @param {boolean} includeCommandLineAPI - * @param {boolean} doNotPauseOnExceptionsAndMuteConsole + * @param {boolean} silent * @param {boolean} returnByValue * @param {boolean} generatePreview * @param {boolean} userGesture * @param {function(?WebInspector.RemoteObject, !RuntimeAgent.ExceptionDetails=)} callback */ - evaluate: function(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, userGesture, callback) + evaluate: function(expression, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, userGesture, callback) { // FIXME: It will be moved to separate ExecutionContext. if (this.debuggerModel.selectedCallFrame()) { - this.debuggerModel.evaluateOnSelectedCallFrame(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, callback); + this.debuggerModel.evaluateOnSelectedCallFrame(expression, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, callback); return; } this._evaluateGlobal.apply(this, arguments); @@ -577,13 +577,13 @@ WebInspector.ExecutionContext.prototype = { * @param {string} expression * @param {string} objectGroup * @param {boolean} includeCommandLineAPI - * @param {boolean} doNotPauseOnExceptionsAndMuteConsole + * @param {boolean} silent * @param {boolean} returnByValue * @param {boolean} generatePreview * @param {boolean} userGesture * @param {function(?WebInspector.RemoteObject, !RuntimeAgent.ExceptionDetails=)} callback */ - _evaluateGlobal: function(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, userGesture, callback) + _evaluateGlobal: function(expression, objectGroup, includeCommandLineAPI, silent, returnByValue, generatePreview, userGesture, callback) { if (!expression) { // There is no expression, so the completion should happen against global properties. @@ -605,7 +605,7 @@ WebInspector.ExecutionContext.prototype = { } callback(this.runtimeModel.createRemoteObject(result), exceptionDetails); } - this.target().runtimeAgent().evaluate(expression, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, this.id, returnByValue, generatePreview, userGesture, false, evalCallback.bind(this)); + this.target().runtimeAgent().evaluate(expression, objectGroup, includeCommandLineAPI, silent, this.id, returnByValue, generatePreview, userGesture, false, evalCallback.bind(this)); }, /** diff --git a/front_end/sdk/ServiceWorkerManager.js b/front_end/sdk/ServiceWorkerManager.js index f24c6b31ab..fb6a4595ce 100644 --- a/front_end/sdk/ServiceWorkerManager.js +++ b/front_end/sdk/ServiceWorkerManager.js @@ -439,7 +439,7 @@ WebInspector.ServiceWorker = function(manager, workerId, url, versionId) this._target = WebInspector.targetManager.createTarget(this._name, capabilities, this._connection, manager.target()); this._target[WebInspector.ServiceWorker.Symbol] = this; this._manager.dispatchEventToListeners(WebInspector.ServiceWorkerManager.Events.WorkersUpdated); - this._target.runtimeAgent().run(); + this._target.runtimeAgent().runIfWaitingForDebugger(); } WebInspector.ServiceWorker.Symbol = Symbol("serviceWorker"); diff --git a/front_end/sdk/WorkerManager.js b/front_end/sdk/WorkerManager.js index 3bde9307c1..a697306df9 100644 --- a/front_end/sdk/WorkerManager.js +++ b/front_end/sdk/WorkerManager.js @@ -109,7 +109,7 @@ WebInspector.WorkerManager.prototype = { var mainIsServiceWorker = WebInspector.targetManager.mainTarget().hasWorkerCapability() && !WebInspector.targetManager.mainTarget().hasBrowserCapability(); if (mainIsServiceWorker && waitingForDebugger) target.debuggerAgent().pause(); - target.runtimeAgent().run(); + target.runtimeAgent().runIfWaitingForDebugger(); }, /** diff --git a/front_end/snippets/ScriptSnippetModel.js b/front_end/snippets/ScriptSnippetModel.js index 29118ce02c..f51798300b 100644 --- a/front_end/snippets/ScriptSnippetModel.js +++ b/front_end/snippets/ScriptSnippetModel.js @@ -270,7 +270,7 @@ WebInspector.ScriptSnippetModel.prototype = { _runScript: function(scriptId, executionContext, sourceURL) { var target = executionContext.target(); - target.runtimeModel.runScript(scriptId, executionContext.id, "console", /* doNotPauseOnExceptionsAndMuteConsole */ false, /* includeCommandLineAPI */ true, /* returnByValue */ false, /* generatePreview */ true, /* awaitPromise */ undefined, runCallback.bind(this, target)); + target.runtimeModel.runScript(scriptId, executionContext.id, "console", /* silent */ false, /* includeCommandLineAPI */ true, /* returnByValue */ false, /* generatePreview */ true, /* awaitPromise */ undefined, runCallback.bind(this, target)); /** * @param {!WebInspector.Target} target diff --git a/front_end/timeline/timelineStatusDialog.css b/front_end/timeline/timelineStatusDialog.css index 846e7f4d6f..1acffc4eea 100644 --- a/front_end/timeline/timelineStatusDialog.css +++ b/front_end/timeline/timelineStatusDialog.css @@ -10,9 +10,8 @@ padding: 12px 16px; align-self: center; background-color: white; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + border: 1px solid lightgrey; + box-shadow: grey 0 0 14px; margin-top: -1px; } diff --git a/front_end/ui/dialog.css b/front_end/ui/dialog.css index 7a3df44ec7..36fbdfd430 100644 --- a/front_end/ui/dialog.css +++ b/front_end/ui/dialog.css @@ -6,9 +6,8 @@ :host { position: absolute; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + border: 1px solid rgb(204, 204, 204); + box-shadow: rgb(140, 140, 140) 0 3px 14px; background: white; justify-content: flex-start; align-items: stretch; diff --git a/front_end/ui/inspectorCommon.css b/front_end/ui/inspectorCommon.css index 9bc0fef343..45ddbb882b 100644 --- a/front_end/ui/inspectorCommon.css +++ b/front_end/ui/inspectorCommon.css @@ -187,9 +187,8 @@ input[type="text"]:focus { .editing { -webkit-user-select: text; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: rgba(0, 0, 0, .5) 3px 3px 4px; + outline: 1px solid rgb(66%, 66%, 66%) !important; background-color: white; -webkit-user-modify: read-write-plaintext-only; text-overflow: clip !important; diff --git a/front_end/ui/suggestBox.css b/front_end/ui/suggestBox.css index 085b8b0b8c..52bb4bbde4 100644 --- a/front_end/ui/suggestBox.css +++ b/front_end/ui/suggestBox.css @@ -72,9 +72,7 @@ display: flex; flex-direction: column; flex: 0 0 auto; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.05), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: 0 0 2px hsla(0, 0%, 0%, 0.3); } .suggest-box .suggest-box-content-item { diff --git a/front_end/ui/textPrompt.css b/front_end/ui/textPrompt.css index e0f93cef73..54e7a41de2 100644 --- a/front_end/ui/textPrompt.css +++ b/front_end/ui/textPrompt.css @@ -6,9 +6,8 @@ .text-prompt-editing { -webkit-user-select: text; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.2), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: rgba(0, 0, 0, .5) 3px 3px 4px; + outline: 1px solid rgb(66%, 66%, 66%) !important; background-color: white; -webkit-user-modify: read-write-plaintext-only; text-overflow: clip !important; diff --git a/front_end/ui_lazy/filteredListWidget.css b/front_end/ui_lazy/filteredListWidget.css index ab169660a4..0f3299b738 100644 --- a/front_end/ui_lazy/filteredListWidget.css +++ b/front_end/ui_lazy/filteredListWidget.css @@ -13,7 +13,7 @@ .filtered-list-widget-prompt-element { flex: 0 0 36px; border: 0; - border-bottom:1px solid rgba(0, 0, 0, 0.2); + box-shadow: rgba(140, 140, 140, 0.2) 0 2px 2px; margin: 0; padding: 0 6px; z-index: 1; diff --git a/front_end/ui_lazy/flameChart.css b/front_end/ui_lazy/flameChart.css index b6aef7c74a..ef387fea1e 100644 --- a/front_end/ui_lazy/flameChart.css +++ b/front_end/ui_lazy/flameChart.css @@ -86,9 +86,7 @@ background-color: white; pointer-events: none; padding: 2px; - box-shadow: 0 0 0 1px rgba(0, 0, 0, 0.05), - 0 2px 4px rgba(0, 0, 0, 0.2), - 0 2px 6px rgba(0, 0, 0, 0.1); + box-shadow: hsla(0, 0%, 0%, 0.4) 1px 1px 8px; } .flame-chart-entry-info table tr td:empty {