squash 'resources/unpacked/devtools' changes from 87b161b..e71b776

e71b776 DevTools: fix 'Make a copy' context menu item in navigator
99bb354 DevTools: get rid of hand-crafted binary search in SourceMap.findEntry
c3b7bfe [Devtools] Restructure network nodes for friendlier products/grouping
aeac81e [DevTools] Enable "auto attach to sub frames" by default
1bbdb1c DevTools: add command menu entries for adding new snippet, workspace folder
f950ef8 DevTools: support uiLocationToRawLocations for CSS
cab282d DevTools: Roll lighthouse w/ artifact delivery
ab11d5c [Devtools] Fix network grouping experiment
624ea04 DevTools: Migrate from -webkit-user-modify to contenteditable
dff718f Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ )
59c0d0a DevTools: Fix "Unwanted blue dot is seen in 'Performance' section of devtools"
85245cf DevTools: Make domains promisified by default
7cefcda DevTools: Remove script/OWNERS

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: e71b776

Author: darwin

BUILD.gn

@@ -318,7 +318,7 @@ all_devtools_files = [
   "front_end/network/networkLogView.css",
   "front_end/network/NetworkLogView.js",
   "front_end/network/NetworkLogViewColumns.js",
-  "front_end/network/NetworkGroupers.js",
+  "front_end/network/NetworkFrameGrouper.js",
   "front_end/network/networkManageCustomHeadersView.css",
   "front_end/network/NetworkManageCustomHeadersView.js",
   "front_end/network/NetworkOverview.js",

front_end/audits2/Audits2Panel.js

@@ -500,7 +500,7 @@ Audits2.Audits2Panel.TreeElement = class extends UI.TreeElement {
       return;
     }
 
-    this._reportContainer = this._resultsView.createChild('div', 'report-container lh-root');
+    this._reportContainer = this._resultsView.createChild('div', 'report-container lh-vars lh-root');
 
     var dom = new DOM(/** @type {!Document} */ (this._resultsView.ownerDocument));
     var detailsRenderer = new DetailsRenderer(dom);
@@ -528,7 +528,7 @@ Audits2.Audits2Panel.TreeSubElement = class extends UI.TreeElement {
     this._id = id;
     this.listItemElement.textContent = name;
     var label = Util.calculateRating(score);
-    var subtitleElement = this.listItemElement.createChild('span', 'lh-root audits2-tree-subtitle-' + label);
+    var subtitleElement = this.listItemElement.createChild('span', 'lh-vars audits2-tree-subtitle-' + label);
     subtitleElement.textContent = String(Math.round(score));
   }
 

front_end/audits2/audits2Tree.css

@@ -20,8 +20,6 @@
   flex: auto;
   text-align: end;
   margin-right: 10px;
-  font-size: inherit;
-  background: inherit;
 }
 
 .audits2-tree-subtitle-pass {
@@ -34,4 +32,4 @@
 
 .audits2-tree-subtitle-fail {
   color: var(--fail-color);
-}
+}

front_end/audits2/lighthouse/renderer/category-renderer.js

@@ -56,11 +56,15 @@ class CategoryRenderer {
 
     // Append audit details to header section so the entire audit is within a <details>.
     const header = /** @type {!HTMLDetailsElement} */ (this._dom.find('.lh-score__header', tmpl));
-    header.open = audit.score < 100; // expand failed audits
     if (audit.result.details) {
       header.appendChild(this._detailsRenderer.render(audit.result.details));
     }
 
+    const scoreEl = this._dom.find('.lh-score', tmpl);
+    if (audit.result.informative) {
+      scoreEl.classList.add('lh-score--informative');
+    }
+
     return this._populateScore(tmpl, audit.score, scoringMode, title, description);
   }
 
@@ -93,6 +97,11 @@ class CategoryRenderer {
   _renderCategoryScore(category) {
     const tmpl = this._dom.cloneTemplate('#tmpl-lh-category-score', this._templateContext);
     const score = Math.round(category.score);
+
+    const gaugeContainerEl = this._dom.find('.lh-score__gauge', tmpl);
+    const gaugeEl = this.renderScoreGauge(category);
+    gaugeContainerEl.appendChild(gaugeEl);
+
     return this._populateScore(tmpl, score, 'numeric', category.name, category.description);
   }
 
@@ -142,11 +151,25 @@ class CategoryRenderer {
     return tmpl;
   }
 
+  /**
+   * @param {!ReportRenderer.CategoryJSON} category
+   * @param {!Object<string, !ReportRenderer.GroupJSON>} groups
+   * @return {!Element}
+   */
+  render(category, groups) {
+    switch (category.id) {
+      case 'accessibility':
+        return this._renderAccessibilityCategory(category, groups);
+      default:
+        return this._renderDefaultCategory(category);
+    }
+  }
+
   /**
    * @param {!ReportRenderer.CategoryJSON} category
    * @return {!Element}
    */
-  render(category) {
+  _renderDefaultCategory(category) {
     const element = this._dom.createElement('div', 'lh-category');
     element.id = category.id;
     element.appendChild(this._renderCategoryScore(category));
@@ -174,6 +197,89 @@ class CategoryRenderer {
     element.appendChild(passedElem);
     return element;
   }
+
+  /**
+   * @param {!Array<!ReportRenderer.AuditJSON>} audits
+   * @param {!ReportRenderer.GroupJSON} group
+   * @return {!Element}
+   */
+  _renderAuditGroup(audits, group) {
+    const auditGroupElem = this._dom.createElement('details',
+          'lh-audit-group lh-expandable-details');
+    const auditGroupHeader = this._dom.createElement('div',
+          'lh-audit-group__header lh-expandable-details__header');
+    auditGroupHeader.textContent = group.title;
+
+    const auditGroupDescription = this._dom.createElement('div', 'lh-audit-group__description');
+    auditGroupDescription.textContent = group.description;
+
+    const auditGroupSummary = this._dom.createElement('summary',
+          'lh-audit-group__summary lh-expandable-details__summary');
+    const auditGroupArrow = this._dom.createElement('div', 'lh-toggle-arrow', {
+      title: 'See audits',
+    });
+    auditGroupSummary.appendChild(auditGroupHeader);
+    auditGroupSummary.appendChild(auditGroupArrow);
+
+    auditGroupElem.appendChild(auditGroupSummary);
+    auditGroupElem.appendChild(auditGroupDescription);
+    audits.forEach(audit => auditGroupElem.appendChild(this._renderAudit(audit)));
+    return auditGroupElem;
+  }
+
+  /**
+   * @param {!ReportRenderer.CategoryJSON} category
+   * @param {!Object<string, !ReportRenderer.GroupJSON>} groupDefinitions
+   * @return {!Element}
+   */
+  _renderAccessibilityCategory(category, groupDefinitions) {
+    const element = this._dom.createElement('div', 'lh-category');
+    element.id = category.id;
+    element.appendChild(this._renderCategoryScore(category));
+
+    const auditsGroupedByGroup = /** @type {!Object<string,
+        {passed: !Array<!ReportRenderer.AuditJSON>,
+        failed: !Array<!ReportRenderer.AuditJSON>}>} */ ({});
+    category.audits.forEach(audit => {
+      const groupId = audit.group;
+      const groups = auditsGroupedByGroup[groupId] || {passed: [], failed: []};
+
+      if (audit.score === 100) {
+        groups.passed.push(audit);
+      } else {
+        groups.failed.push(audit);
+      }
+
+      auditsGroupedByGroup[groupId] = groups;
+    });
+
+    const passedElements = /** @type {!Array<!Element>} */ ([]);
+    Object.keys(auditsGroupedByGroup).forEach(groupId => {
+      const group = groupDefinitions[groupId];
+      const groups = auditsGroupedByGroup[groupId];
+      if (groups.failed.length) {
+        const auditGroupElem = this._renderAuditGroup(groups.failed, group);
+        auditGroupElem.open = true;
+        element.appendChild(auditGroupElem);
+      }
+
+      if (groups.passed.length) {
+        const auditGroupElem = this._renderAuditGroup(groups.passed, group);
+        passedElements.push(auditGroupElem);
+      }
+    });
+
+    // don't create a passed section if there are no passed
+    if (!passedElements.length) return element;
+
+    const passedElem = this._dom.createElement('details', 'lh-passed-audits');
+    const passedSummary = this._dom.createElement('summary', 'lh-passed-audits-summary');
+    passedElem.appendChild(passedSummary);
+    passedSummary.textContent = `View ${passedElements.length} passed items`;
+    passedElements.forEach(elem => passedElem.appendChild(elem));
+    element.appendChild(passedElem);
+    return element;
+  }
 }
 
 if (typeof module !== 'undefined' && module.exports) {

front_end/audits2/lighthouse/renderer/report-renderer.js

@@ -149,7 +149,7 @@ class ReportRenderer {
     const categories = reportSection.appendChild(this._dom.createElement('div', 'lh-categories'));
     for (const category of report.reportCategories) {
       scoreHeader.appendChild(this._categoryRenderer.renderScoreGauge(category));
-      categories.appendChild(this._categoryRenderer.render(category));
+      categories.appendChild(this._categoryRenderer.render(category, report.reportGroups));
     }
 
     reportSection.appendChild(this._renderReportFooter(report));
@@ -169,8 +169,10 @@ if (typeof module !== 'undefined' && module.exports) {
  *     id: string,
  *     weight: number,
  *     score: number,
+ *     group: string,
  *     result: {
  *       description: string,
+ *       informative: boolean,
  *       debugString: string,
  *       displayValue: string,
  *       helpText: string,
@@ -195,13 +197,23 @@ ReportRenderer.AuditJSON; // eslint-disable-line no-unused-expressions
  */
 ReportRenderer.CategoryJSON; // eslint-disable-line no-unused-expressions
 
+/**
+ * @typedef {{
+ *     title: string,
+ *     description: string,
+ * }}
+ */
+ReportRenderer.GroupJSON; // eslint-disable-line no-unused-expressions
+
 /**
  * @typedef {{
  *     lighthouseVersion: string,
  *     generatedTime: string,
  *     initialUrl: string,
  *     url: string,
+ *     artifacts: {traces: !Object},
  *     reportCategories: !Array<!ReportRenderer.CategoryJSON>,
+ *     reportGroups: !Object<string, !ReportRenderer.GroupJSON>,
  *     runtimeConfig: {
  *       blockedUrlPatterns: !Array<string>,
  *       environment: !Array<{description: string, enabled: boolean, name: string}>