Skip to content

Commit 8c93cca

Browse files
dgozmanCommit bot
authored andcommitted
[DevTools] Remove network headers filter experiment.
BUG=none Review URL: https://codereview.chromium.org/1889913004 Cr-Commit-Position: refs/heads/master@{#388098}
1 parent bc577d1 commit 8c93cca

File tree

2 files changed

+2
-56
lines changed

2 files changed

+2
-56
lines changed

front_end/main/Main.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ WebInspector.Main.prototype = {
113113
Runtime.experiments.register("inspectTooltip", "Dark inspect element tooltip");
114114
Runtime.experiments.register("liveSASS", "Live SASS", true);
115115
Runtime.experiments.register("multipleTimelineViews", "Multiple main views on Timeline", true);
116-
Runtime.experiments.register("networkRequestHeadersFilterInDetailsView", "Network request headers filter in details view", true);
117116
Runtime.experiments.register("networkRequestsOnTimeline", "Network requests on Timeline", true);
118117
Runtime.experiments.register("privateScriptInspection", "Private script inspection");
119118
Runtime.experiments.register("reducedIndentation", "Reduced indentation in Elements DOM tree");

front_end/network/RequestHeadersView.js

Lines changed: 2 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,6 @@ WebInspector.RequestHeadersView = function(request)
4444
this._showRequestHeadersText = false;
4545
this._showResponseHeadersText = false;
4646

47-
this._requestHeaderFilterSetting = WebInspector.settings.createSetting("requestHeaderFilterSetting", "");
48-
49-
/** @type {?RegExp} */
50-
this._filterRegex = null;
51-
if (Runtime.experiments.isEnabled("networkRequestHeadersFilterInDetailsView")) {
52-
this._filterInput = this.element.createChild("input", "filter-input");
53-
this._filterInput.type = "text";
54-
this._filterInput.placeholder = WebInspector.UIString("Filter headers");
55-
this._filterInput.addEventListener("input", this._updateFilter.bind(this), false);
56-
this._filterInput.addEventListener("keydown", this._onFilterKeyDown.bind(this), false);
57-
this._filterInput.value = this._requestHeaderFilterSetting.get() || "";
58-
}
59-
6047
var root = new TreeOutline(true);
6148
root.element.classList.add("outline-disclosure");
6249
root.expandTreeElementsWhenArrowing = true;
@@ -75,43 +62,9 @@ WebInspector.RequestHeadersView = function(request)
7562
this._queryStringCategory = new WebInspector.RequestHeadersView.Category(root, "queryString", "");
7663
this._formDataCategory = new WebInspector.RequestHeadersView.Category(root, "formData", "");
7764
this._requestPayloadCategory = new WebInspector.RequestHeadersView.Category(root, "requestPayload", WebInspector.UIString("Request Payload"));
78-
79-
80-
if (Runtime.experiments.isEnabled("networkRequestHeadersFilterInDetailsView")) {
81-
this._updateFilter();
82-
}
8365
}
8466

8567
WebInspector.RequestHeadersView.prototype = {
86-
_updateFilter: function()
87-
{
88-
var text = this._filterInput.value;
89-
this._requestHeaderFilterSetting.set(text);
90-
this._filterRegex = text ? new RegExp(text.escapeForRegExp(), "i") : null;
91-
this._updateHeaders();
92-
},
93-
94-
/**
95-
* @param {!Event} event
96-
*/
97-
_onFilterKeyDown: function(event)
98-
{
99-
var text = this._filterInput.value;
100-
if (!text)
101-
return;
102-
if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc.code || event.keyIdentifier === "U+001B") {
103-
event.consume(true);
104-
this._filterInput.value = "";
105-
this._updateFilter();
106-
}
107-
},
108-
109-
_updateHeaders: function()
110-
{
111-
this._refreshRequestHeaders();
112-
this._refreshResponseHeaders();
113-
},
114-
11568
wasShown: function()
11669
{
11770
this._request.addEventListener(WebInspector.NetworkRequest.Events.RemoteAddressChanged, this._refreshRemoteAddress, this);
@@ -121,7 +74,8 @@ WebInspector.RequestHeadersView.prototype = {
12174

12275
this._refreshURL();
12376
this._refreshQueryString();
124-
this._updateHeaders();
77+
this._refreshRequestHeaders();
78+
this._refreshResponseHeaders();
12579
this._refreshHTTPInformation();
12680
this._refreshRemoteAddress();
12781
},
@@ -345,11 +299,7 @@ WebInspector.RequestHeadersView.prototype = {
345299
_refreshRequestHeaders: function()
346300
{
347301
var treeElement = this._requestHeadersCategory;
348-
349302
var headers = this._request.requestHeaders().slice();
350-
var filterRegex = this._filterRegex;
351-
if (filterRegex)
352-
headers = headers.filter(function(header) { return filterRegex.test(header.name) || filterRegex.test(header.value);});
353303
headers.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()); });
354304
var headersText = this._request.requestHeadersText();
355305

@@ -371,9 +321,6 @@ WebInspector.RequestHeadersView.prototype = {
371321
{
372322
var treeElement = this._responseHeadersCategory;
373323
var headers = this._request.sortedResponseHeaders.slice();
374-
var filterRegex = this._filterRegex;
375-
if (filterRegex)
376-
headers = headers.filter(function(header) { return filterRegex.test(header.name) || filterRegex.test(header.value);});
377324
var headersText = this._request.responseHeadersText;
378325

379326
if (this._showResponseHeadersText)

0 commit comments

Comments
 (0)