Skip to content

Commit 8f72fab

Browse files
JoelEinbinderCommit bot
authored andcommitted
Revert of DevTools: Move radio button input element into Shadow DOM (patchset #1 id:1 of https://codereview.chromium.org/2650213005/ )
Reason for revert: Breaks all the radio buttons Original issue's description: > DevTools: Move radio button input element into Shadow DOM > > BUG=685385 > > Review-Url: https://codereview.chromium.org/2650213005 > Cr-Commit-Position: refs/heads/master@{#446606} > Committed: https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685385 Review-Url: https://codereview.chromium.org/2661623003 Cr-Commit-Position: refs/heads/master@{#446843}
1 parent 0f63c02 commit 8f72fab

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

front_end/network/networkConfigView.css

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,11 @@
5757
line-height: 20px;
5858
}
5959

60-
.network-config-ua input {
60+
.network-config-ua label[is="dt-radio"].checked > * {
61+
display: none
62+
}
63+
64+
.network-config-ua input:not(.dt-radio-button) {
6165
display: block;
6266
width: calc(100% - 20px);
6367
max-width: 250px;
@@ -89,6 +93,10 @@
8993
max-width: 250px;
9094
}
9195

96+
.network-config-ua label[is="dt-radio"] {
97+
display: block;
98+
}
99+
92100
.network-config-ua-auto, .network-config-ua-custom {
93101
opacity: 0.5;
94102
}

front_end/ui/UIUtils.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1359,9 +1359,10 @@ UI.appendStyle = function(node, cssFile) {
13591359
* @this {Element}
13601360
*/
13611361
createdCallback: function() {
1362-
var root = UI.createShadowRootWithCoreStyles(this, 'ui/radioButton.css');
1363-
this.radioElement = root.createChild('input', 'dt-radio-button');
1362+
this.radioElement = this.createChild('input', 'dt-radio-button');
13641363
this.radioElement.type = 'radio';
1364+
var root = UI.createShadowRootWithCoreStyles(this, 'ui/radioButton.css');
1365+
root.createChild('content').select = '.dt-radio-button';
13651366
root.createChild('content');
13661367
this.addEventListener('click', radioClickHandler, false);
13671368
},

front_end/ui/radioButton.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* found in the LICENSE file.
55
*/
66

7-
.dt-radio-button {
7+
::content .dt-radio-button {
88
height: 17px;
99
width: 17px;
1010
min-width: 17px;
@@ -16,16 +16,16 @@
1616
margin: 0 5px 5px 0;
1717
}
1818

19-
.dt-radio-button:active:not(:disabled) {
19+
::content .dt-radio-button:active:not(:disabled) {
2020
background-image: linear-gradient(to bottom, rgb(194, 194, 194), rgb(239, 239, 239));
2121
}
2222

23-
.dt-radio-button:checked {
23+
::content .dt-radio-button:checked {
2424
background: url(Images/radioDot.png) center no-repeat,
2525
linear-gradient(to bottom, rgb(252, 252, 252), rgb(223, 223, 223));
2626
}
2727

28-
.dt-radio-button:checked:active {
28+
::content .dt-radio-button:checked:active {
2929
background: url(Images/radioDot.png) center no-repeat,
3030
linear-gradient(to bottom, rgb(194, 194, 194), rgb(239, 239, 239));
3131
}

0 commit comments

Comments
 (0)